Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E827C43331 for ; Mon, 30 Mar 2020 13:26:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0955D20733 for ; Mon, 30 Mar 2020 13:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="InuGNN0I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0955D20733 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIuQT-0008Ee-8Y; Mon, 30 Mar 2020 13:26:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIuQS-0008EZ-2V for xen-devel@lists.xenproject.org; Mon, 30 Mar 2020 13:26:00 +0000 X-Inumbo-ID: fead9a26-7289-11ea-b9d8-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fead9a26-7289-11ea-b9d8-12813bfff9fa; Mon, 30 Mar 2020 13:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=7fc3wTxRBoeTBIkFvmlGwjiCbYGeE4KFWQBhDgkH8lo=; b=InuGNN0IoFv2N7oYlaIgsUOUiN MZPUTDHqcqdzu0qIt8s9z6GU1fbXqhbKDPrmUHLNWVJO3rvEun2w3lMo/SodFxlw17qih3CgD2asJ K2oU8Dzzb3r5Art5blEsA5Rjh8C+HWSCrB2m3g5BoPAYggQTV0GCtccRJMTV0OJ1Uz6U=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jIuQR-0004hs-1y; Mon, 30 Mar 2020 13:25:59 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jIuQQ-0007GJ-P0; Mon, 30 Mar 2020 13:25:58 +0000 Date: Mon, 30 Mar 2020 14:25:56 +0100 From: Wei Liu To: Jason Andryuk Message-ID: <20200330132556.fjskeqkqlpd6g2er@debian> References: <20200312145417.106812-1-jandryuk@gmail.com> <20200312145417.106812-3-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312145417.106812-3-jandryuk@gmail.com> User-Agent: NeoMutt/20180716 Subject: Re: [Xen-devel] [PATCH 2/2] scripts: Use stat to check lock claim X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Mar 12, 2020 at 10:54:17AM -0400, Jason Andryuk wrote: > Replace the perl locking check with stat(1). Stat is able to fstat > stdin (file descriptor 0) when passed '-' as an argument. This is now > used to check $_lockfd. stat(1) support for '-' was introduced to > coreutils in 2009. > > After A releases its lock, script B will return from flock and execute > stat. Since the lockfile has been removed by A, stat prints an error to > stderr and exits non-zero. Redirect stderr to /dev/null to avoid > filling /var/log/xen/xen-hotplug.log with "No such file or directory" > messages. > > Placing the stat call inside the "if" condition ensures we only check > the stat output when the command completed successfully. > > This change removes the only runtime dependency of the xen toolstack on > perl. > > Suggested-by: Ian Jackson > Signed-off-by: Jason Andryuk Ian, ping? I already applied patch 1. This patch looks to be good as well. Wei.