Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64D0C43331 for ; Mon, 30 Mar 2020 15:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A52620781 for ; Mon, 30 Mar 2020 15:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585580834; bh=dXSoazegFX+RNdtyXJI6zjS7f/1824oaHkoXykcp9nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cZ2I0qCigqzAaOFcHWyUux2nAe0d8nVVeodtDsmwyaFn1gr/VAr1VO+a17wXCcRYF TWCaGItlIOS2xcaty4IkDafH3MAtBddYmbuM+lGsSIcdHSA/R2RjURo8UcQYU5Z/RZ kISWh95S9qf5jZEFVm2rjMtAxqisoAHwn7M5g6gI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728266AbgC3PHN (ORCPT ); Mon, 30 Mar 2020 11:07:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgC3PHN (ORCPT ); Mon, 30 Mar 2020 11:07:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3221B20658; Mon, 30 Mar 2020 15:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585580832; bh=dXSoazegFX+RNdtyXJI6zjS7f/1824oaHkoXykcp9nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fwQ0Zi/pO+WadpGwXm7/Fv6ON/vWepu7s3hG1WX0+cRs64pqmUefYkLV22V5UWSEl 6xW5oMEVij4b9AxpgcsJgmn51F8HbTYgwkGb5by2ODjolmAUi3yufHeOuact3adyFG 06X4KnBNR+3W+smJaD5dJ+N8MWk79ib9ZLBTvz9I= Date: Mon, 30 Mar 2020 17:07:10 +0200 From: Greg Kroah-Hartman To: Heiner Kallweit Cc: David Miller , nic_swsd@realtek.com, cwhuang@android-x86.org, netdev@vger.kernel.org Subject: Re: issue with 85a19b0e31e2 on 4.19 -> revert Message-ID: <20200330150710.GA614751@kroah.com> References: <40373530-6d40-4358-df58-13622a4512c2@gmail.com> <20200327.155753.1558332088898122758.davem@davemloft.net> <20200327.162400.1906897622883505835.davem@davemloft.net> <05d53fd2-f210-1963-96d1-2dc3d0a3a8c7@gmail.com> <20200330143038.GA449036@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 30, 2020 at 04:39:08PM +0200, Heiner Kallweit wrote: > On 30.03.2020 16:30, Greg Kroah-Hartman wrote: > > On Sat, Mar 28, 2020 at 10:52:19AM +0100, Heiner Kallweit wrote: > >> On 28.03.2020 00:24, David Miller wrote: > >>> From: Heiner Kallweit > >>> Date: Sat, 28 Mar 2020 00:10:57 +0100 > >>> > >>>> Somehow that change made it to -stable. See e.g. commit > >>>> 85a19b0e31e256e77fd4124804b9cec10619de5e for 4.19. > >>> > >>> This is a serious issue in that it seems that the people maintaining > >>> the older stable release integrate arbitrary patches even if they > >>> haven't been sent to v5.4 and v5.5 > >>> > >>> And I don't handle -stable backport submissions that far back anyways. > >>> > >>> Therefore, I'm not going to participate in that ongoing problem, so > >>> feel free to contact the folks who integrated those changes into > >>> -stable and ask them to revert. > >>> > >>> Thanks. > >>> > >> Greg, > >> > >> commit 85a19b0e31e2 ("r8169: check that Realtek PHY driver module is loaded") > >> made it accidentally to 4.19 and causes an issue with Android/x86. > >> Could you please revert it? > > > > Now reverted. Should I also drop this from 5.4.y and 5.5.y? > > > Thanks! On 5.4 and 5.5 it's not needed to revert. The following fix from 5.6 > should make it to 5.4 and 5.5 soon. > > 2e8c339b4946 ("r8169: fix PHY driver check on platforms w/o module softdeps") I don't see it in David's queue, so I'll go take it now for those trees. thanks, greg k-h