Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBCEC43331 for ; Tue, 31 Mar 2020 07:54:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93674206F5 for ; Tue, 31 Mar 2020 07:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="dSfOZKBl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93674206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 174366E5A3; Tue, 31 Mar 2020 07:54:14 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id A82C46E5A3 for ; Tue, 31 Mar 2020 07:54:12 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id a25so24699223wrd.0 for ; Tue, 31 Mar 2020 00:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gvz3GQ1RMEPStxdr13lCEex9B91GOeTShqCsPDnnxQM=; b=dSfOZKBl47xF+2V/D8B5DBtvHMfNGGeqS+2Yi8Mv8UE/3FxFiKdwQMpjOPj4Ahx5Bu +Gagcce+p8uwM8yll7DZzyGJ7TZNMGc6TjOpQT3sN8dMQlkMC7o/nI6OuSmEGncrffVn ewcArP1LYxpH6XSIzJVx2+qwyKwdoWb0BBUqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gvz3GQ1RMEPStxdr13lCEex9B91GOeTShqCsPDnnxQM=; b=pRcRZ0LJ/Rc13JpD0C5H1zi3vZjQvqcMYt/beETYpSdd8ThBYT0iOaaUpg+thQS+Df EsLvJ9wQAAhaIz4pMByvf3s4stw8CseatpHoD4TkEUJ1f8Z9MF66V7CN217EjOoFEsOU 98XnO2tJcasLmcEw7UILOGvSg2R7LsiBCBXB8jKOjd5PtDLzKZMIgia0Z/80tiMJdMA7 4MaxvpE8FvDmxF3HHM/TbILRhSOPOwbFst3o8K+vB0tyUFoW3KRAprK4LEvU2/jqJ+gK Pr8YiTQgVunZqfnRuOKxlVOFmmBP7CjZbEBtHAYQOzF112JC1+JFBEP48s8qR7rF2Wr2 Iv4g== X-Gm-Message-State: ANhLgQ2ZObpJ3DhupEWFWmMZ69oTtdJQxlQpem3jtX3CuZ2m1xl4bsfX 8Wc62UPFsj/HMNRPkyekoUgLgw== X-Google-Smtp-Source: ADFU+vuUQhzSqlT9NlG7iXSgaOr9DEeV8OdGKHKhQBQzklwRJs4jbglZeTnsdKgQnK77e0/4qP27KQ== X-Received: by 2002:adf:f0c5:: with SMTP id x5mr19143796wro.415.1585641251388; Tue, 31 Mar 2020 00:54:11 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h10sm26525046wrq.33.2020.03.31.00.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 00:54:10 -0700 (PDT) Date: Tue, 31 Mar 2020 09:54:08 +0200 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH v1 3/6] drm/sched: fix kernel-doc in gpu_scheduler.h Message-ID: <20200331075408.GG2363188@phenom.ffwll.local> References: <20200328132025.19910-1-sam@ravnborg.org> <20200328132025.19910-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200328132025.19910-4-sam@ravnborg.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Andrzej Hajda , Nirmoy Das , Laurent Pinchart , Mihail Atanassov , Emil Velikov , David Francis , James Qian Wang , Thomas Zimmermann , Jonas Karlman , Mikita Lipski , Jernej Skrabec , Andrzej Pietrasiewicz , Boris Brezillon , Alex Deucher Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Mar 28, 2020 at 02:20:22PM +0100, Sam Ravnborg wrote: > Fix following warning: > gpu_scheduler.h:103: warning: Function parameter or member 'priority' not described in 'drm_sched_entity' > > Signed-off-by: Sam Ravnborg > Cc: Nirmoy Das > Cc: David Airlie > Cc: Daniel Vetter Inline struct comments would be really nice here. Otherwise Acked-by: Daniel Vetter > --- > include/drm/gpu_scheduler.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h > index 26b04ff62676..a21b3b92135a 100644 > --- a/include/drm/gpu_scheduler.h > +++ b/include/drm/gpu_scheduler.h > @@ -56,6 +56,7 @@ enum drm_sched_priority { > * Jobs from this entity can be scheduled on any scheduler > * on this list. > * @num_sched_list: number of drm_gpu_schedulers in the sched_list. > + * @priority: priority of the entity > * @rq_lock: lock to modify the runqueue to which this entity belongs. > * @job_queue: the list of jobs of this entity. > * @fence_seq: a linearly increasing seqno incremented with each > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel