From: Wolfgang Denk Date: Wed, 01 Apr 2020 13:34:01 +0200 Subject: [PATCH 09/16] board: stm32mp1: gt9147 IRQ before reset on EV1 In-Reply-To: <20200331180330.9.I5d296f8fd82b60a592b51029e7e420672d0e855b@changeid> References: <20200331180330.1.Ied6708bad5048382a57618f95d67c549aae49f42@changeid> <20200331180330.9.I5d296f8fd82b60a592b51029e7e420672d0e855b@changeid> Message-ID: <20200401113401.DB2B124003E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Patrick Delaunay, In message <20200331180330.9.I5d296f8fd82b60a592b51029e7e420672d0e855b@changeid> you wrote: > Software workaround for I2C issue on EV1 board, > configure the IRQ line for touchscreen before LCD reset > to fix the used I2C address. ... > + ret = uclass_get_device_by_driver(UCLASS_NOP, DM_GET_DRIVER(goodix), > + &dev); > + if (ret) > + debug("goodix init failed: %d\n", ret); If this is an error condition, you should use printf(), and not paper over it with a debug(). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Don't have a battle of wits with an unarmed opponent.