Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jKgWH-0002ec-IH for mharc-grub-devel@gnu.org; Sat, 04 Apr 2020 06:59:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43005) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKgWF-0002eQ-A6 for grub-devel@gnu.org; Sat, 04 Apr 2020 06:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKgWE-0006uk-6U for grub-devel@gnu.org; Sat, 04 Apr 2020 06:59:19 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60831) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKgWD-0006pI-Nh for grub-devel@gnu.org; Sat, 04 Apr 2020 06:59:18 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BF4B35C0230; Sat, 4 Apr 2020 06:59:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 04 Apr 2020 06:59:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=4LWVzhX0V73V4wTkracIoFOcZVx KcNfBthzyfjw4B9w=; b=XWYi2aQqsoEnNqWSxlGNAOFgwqwu4G2A9QYz17LaTQY 5pm21gJ6bd9adg2brajMPSf1+0mb2k+9lLY6eHJ5vYVQ07dnU7sWppAlAbYjHSvR x7zdoexa/P+Vb0AcWHyVmW5HhbcNlh2lN9p1723NzJJ6Icye4pIHbXPPglHAu6VF 1wFybgEP5n+74fea/Xp9ekmKzsJeKD3Zv/TFGCZKxa3sZRxEVsMsTOvTd7YgoM+s 7TBnp+ayuqgqJK0nowK4uEhAFSsos+Da3RAqGtMNonmWPH6kSxpozwhgEXkYEk5x ASgkna0aFO2mQaqHcT5PF9xjSFuPVpsd1uAOUMkCojg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4LWVzh X0V73V4wTkracIoFOcZVxKcNfBthzyfjw4B9w=; b=hCpoPRRbxyzPSQpt5YFMQC CAdnzOvPcDOKkH5AcEZDQon4mda/8TeljTg3O+UdhaSdTZwBUzOOSAfG3sBV/fHP zbjEoQ6soHdCZGlI5l7jYuT6xP5nwG+yjqvi40qdSDh4qWKQmVvdN/iIldzSuNpl QZxoMlH9k4V57DitsU6KBQo/3aCAAI+FGA1Nw58I7MejLExe2kd5fIxW2uWQjpXr ZGEcdwX7sOnm16OmFClY8d0XVtuecLcZ3Z4ojhBn/3r5xD6L/78caz/74BTxIhCE vyR1Z5ePAVS7+Cfh9GPpRLsKuZDEF2khkFZgidLtg/ctgIYRqIEYZxcZT89JJ6ww == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdekgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecukfhppeejjedruddurd dugedvrddujeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4d0b8eb1.dyn.telefonica.de [77.11.142.177]) by mail.messagingengine.com (Postfix) with ESMTPA id 52C10306D0AD; Sat, 4 Apr 2020 06:59:14 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 5fb2303d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 4 Apr 2020 10:59:09 +0000 (UTC) Date: Sat, 4 Apr 2020 12:59:10 +0200 From: Patrick Steinhardt To: Denis 'GNUtoo' Carikli Cc: Daniel Kiper , The development of GNU GRUB , John Lane Subject: Re: [PATCHv2][ 3/6] cryptodisk: enable the backends to implement detached headers Message-ID: <20200404105910.GA33905@ncase.pks.im> References: <20200317075740.5430-1-GNUtoo@cyberdimension.org> <20200317075740.5430-3-GNUtoo@cyberdimension.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20200317075740.5430-3-GNUtoo@cyberdimension.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 10:59:20 -0000 --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 17, 2020 at 08:57:37AM +0100, Denis 'GNUtoo' Carikli wrote: [snip] > @@ -1041,7 +1043,7 @@ grub_cryptodisk_cheat_mount (const char *sourcedev,= const char *cheat) > =20 > FOR_CRYPTODISK_DEVS (cr) > { > - dev =3D cr->scan (source, search_uuid, check_boot); > + dev =3D cr->scan (source, search_uuid, check_boot, 0); The added argument is a pointer, right? In that case you should use `NULL` instead of `0`. > if (grub_errno) > return grub_errno; > if (!dev) [snip] > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -242,7 +243,8 @@ grub_util_get_geli_uuid (const char *dev) > #endif > =20 > static grub_cryptodisk_t > -geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only) > +geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only, > + grub_file_t hdr __attribute__((__unused__))) > { > grub_cryptodisk_t newdev; > struct grub_geli_phdr header; > @@ -254,6 +256,7 @@ geli_scan (grub_disk_t disk, const char *check_uuid, = int boot_only) > grub_disk_addr_t sector; > grub_err_t err; > =20 > + This added newline looks like an accidental change. Patrick --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl6IaH4ACgkQVbJhu7ck PpQERxAAm1lGoUBEeRGavewTdJKJ8jo/gBpbSYfQ9V6YQ8p2FawYmcgZDbhrJQkX JB5BT1J8DTQJRusaMtZMRG+aN1/9Y/Q9PeqJOyrJn2tgMjG/vthS1mqhnCaemXnE 5vOTN59NBn0y6NcUDWjdFxsNa0BQn1BnFzIvxRBO2BKtwpwfoENPiFKA8DG2T1Qu PhWZ8qFc5IeDfbFdoVahOK4j3Jte0MKDsGTK+nYAHSrfxu8oit6mvuKapByK4x+J PcNa7BSdHOe0fQvopBrH3EJrGuLFiuyNsoVpXBFvsHJx12jCNcM9E3Pxlk5VI1eS nDdz1wsMBVn5qS+t6M2o/PMX1DC1SiczjcpNuzcR/wfgPlw/klkjHYYfwcXnSgQ1 HYZH6GSA4041U2+7837ijw6SJzdfglLzbt93CPWIp2NQVlgvrIMnlL88ziClxSu2 /HPrco4BbVoEKUWcD5xUTx0tQiaUykCCNp1TG4kBo3kOgb/lzMyKQlkDzG3bh9Fh 39RLt5j4bDC+v2I+cAyFUemewahaoMTH7MKUTNktAif41fzk9eRTHceFJi5qQyhO wrcLCjrRP+EbuU1Rh6Hu7+oBxCq1w4xe/yA2LCtRYEm3Z6MqaVs9Er4Uo1KimE6g Lsx3h+ABa9B7jUMJLfwiVeTA4OZ2I4ULHQoTrlNM2KcoZnGDUdQ= =y2ko -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--