Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jKgc9-0004pt-BY for mharc-grub-devel@gnu.org; Sat, 04 Apr 2020 07:05:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43718) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKgc6-0004oV-Pi for grub-devel@gnu.org; Sat, 04 Apr 2020 07:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKgc5-00051N-Nn for grub-devel@gnu.org; Sat, 04 Apr 2020 07:05:22 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50463) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKgc5-000517-Ju for grub-devel@gnu.org; Sat, 04 Apr 2020 07:05:21 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E260B5C0238; Sat, 4 Apr 2020 07:05:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 04 Apr 2020 07:05:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=TCfwim708jGjQq+CP93B7UdMId8 k9VQ/gx6ucFeLCkY=; b=Qb1hKZLjRtT+V1D+pR1RaYwiTvRGdq7QIvoBlByqH3L FrM+l3WON4m1gmE5fyCBRtdZCn+BvnxWjwqLvnOcR7a0IXVV9Mcd2z/3/A5OER1B hQYw+xTCFbKpS+HdUyfljNoaMvh0d6Y/jRV3FT8QXpBnjGZO0plaio6saknlbvoM GAn8KhcpAfXk/bSUAV+It7ZglW7kMkOgl19KIXKJhwckk4PV6dtREYJY1LfhJXqQ Z7L1NCCP7aF2aZtuXjh0hI8leXAIg9UjCnxhuO556DMU/Ad+tFz79OdchJLbR7NC 932pBBOCGy9ALIk0mxEkcupwUfHYEwrqCJH/0t/QQ5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TCfwim 708jGjQq+CP93B7UdMId8k9VQ/gx6ucFeLCkY=; b=nq+2ThKOAJpjssSa0wXlZp AjkMMrEwXgZN29OeaIXMBUlFTqteZOSEU7pxtQy+9kyw7PTm12X84Lfb+J9L67YO YsQaIpxI278xLlGxZjiOekvIBfFy6M6cuP/IrAvFNrk0FyTi6ClzDs18W27f3HAH yTLn9mkQ71a0DwIxF6rQlaOF5/8Bl1NZbHa8UyUkJBm5a1NwIIzCXCwNulfnwKdU j8LCYi6tzaGjIZf7fRKVhUGMeroDjlUxyFFhd5qUIu/9vZBAgXIdlqXV5L6WPkuy ophowA23GO0e+ZsR6UNlhf3XvM8kxeZFBeIQWEv4cXD511ct70DKDb3pXsPCYa0A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdekgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecukfhppeejjedruddurd dugedvrddujeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4d0b8eb1.dyn.telefonica.de [77.11.142.177]) by mail.messagingengine.com (Postfix) with ESMTPA id F2CC7306D0C8; Sat, 4 Apr 2020 07:05:18 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 0f8cc628 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 4 Apr 2020 11:05:18 +0000 (UTC) Date: Sat, 4 Apr 2020 13:05:18 +0200 From: Patrick Steinhardt To: Denis 'GNUtoo' Carikli Cc: Daniel Kiper , The development of GNU GRUB , John Lane Subject: Re: [PATCHv2][ 3/6] cryptodisk: enable the backends to implement detached headers Message-ID: <20200404110518.GA34655@ncase.pks.im> References: <20200317075740.5430-1-GNUtoo@cyberdimension.org> <20200317075740.5430-3-GNUtoo@cyberdimension.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <20200317075740.5430-3-GNUtoo@cyberdimension.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 11:05:23 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 17, 2020 at 08:57:37AM +0100, Denis 'GNUtoo' Carikli wrote: > From: John Lane > @@ -242,7 +243,8 @@ grub_util_get_geli_uuid (const char *dev) > #endif > =20 > static grub_cryptodisk_t > -geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only) > +geli_scan (grub_disk_t disk, const char *check_uuid, int boot_only, > + grub_file_t hdr __attribute__((__unused__))) > { > grub_cryptodisk_t newdev; > struct grub_geli_phdr header; Hmm. So in case any of the backends gets a non-NULL `hdr` that it can't support, shouldn't we return an error? Otherwise the backend might do something the user didn't intend to do when using `cryptomount -H` e.g. for LUKS2 or Geli. Patrick --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl6Iae4ACgkQVbJhu7ck PpQ1TQ/9GZv0tW/KxNbLBeWReOofIN4NefDz+jd5+870ndjPnX8ogPaC4F78Bp6v TA0Eu767xh4OUvYwPgwUyPvyJH2v1Tqo+UJIwoaIIuBIUEnj3EA2ZfY3kmGyIdDc D8iDhjuG/1R7lFgMP8/4u23FR2lfAcR8DUEJjofMr9tLpX9FTANqw8a7olN0hOyo o/mTuhR5uJTXQm0fOhbCZFCbCiyqvu01XRSj+2x4eU90IoPwNP6TUnvRTxQBBFya +s4oIcRLplsa6LcTPOmcaWQ+QSHZf0ILyOVBsrjNoFrMm2xgNjfuO2aGn+oqnj/B KEYnFqxKo8frFvHTh//GLw7R5PYypVo7EcxOLv/QfmoEa4U0dg71DTAz6KKK/5tq rIllanQeudhCOpz0s8F6NrZwqE5kN2H/IeqPKEfEjn5J73C8L7JjOtYz3sP63Zm2 WgwEo0Gon/+eu6Y5xu65RaAMTbCVoQS2VusTxt/7mV+6cARycQL2CTtRsSlbzmp4 ZTYnr2LlAFXqT9bO5teLDTGO0MLLggIyvmbW21krg2gYr3laN9O3p8pwluvLzu6Y 2jy7oHwNPJq0E3bIp9hBQLq05DXsfrSpd4fl13ALJidHlYGiLXPqYo+JAVmt1R4L Qfmio7w9J1mGeXSgDvYJmsXPVUGlrAgMgNmwLsWMAu6UmbLnDBY= =dYED -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--