From: Qiujun Huang Date: Sun, 05 Apr 2020 09:10:38 +0000 Subject: [PATCH] KVM: PPC: Book3S HV: Remove NULL check before kfree Message-Id: <20200405091038.29822-1-hqjagain@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Qiujun Huang NULL check before kfree is unnecessary, so remove it. This issue was detected by using the Coccinelle software. Signed-off-by: Qiujun Huang --- arch/powerpc/kvm/book3s_hv_nested.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv_nested.c b/arch/powerpc/kvm/book3s_hv_nested.c index dc97e5be76f6..cad324312040 100644 --- a/arch/powerpc/kvm/book3s_hv_nested.c +++ b/arch/powerpc/kvm/book3s_hv_nested.c @@ -1416,8 +1416,7 @@ static long int __kvmhv_nested_page_fault(struct kvm_run *run, rmapp = &memslot->arch.rmap[gfn - memslot->base_gfn]; ret = kvmppc_create_pte(kvm, gp->shadow_pgtable, pte, n_gpa, level, mmu_seq, gp->shadow_lpid, rmapp, &n_rmap); - if (n_rmap) - kfree(n_rmap); + kfree(n_rmap); if (ret = -EAGAIN) ret = RESUME_GUEST; /* Let the guest try again */ -- 2.17.1