Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jLNZO-0006Fv-Hc for mharc-grub-devel@gnu.org; Mon, 06 Apr 2020 04:57:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38444) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLNZL-0006Dc-JD for grub-devel@gnu.org; Mon, 06 Apr 2020 04:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLNZJ-0003qR-Bt for grub-devel@gnu.org; Mon, 06 Apr 2020 04:57:22 -0400 Received: from m9a0013g.houston.softwaregrp.com ([15.124.64.91]:36331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jLNZJ-0003k9-4D for grub-devel@gnu.org; Mon, 06 Apr 2020 04:57:21 -0400 Received: FROM m9a0013g.houston.softwaregrp.com (15.121.0.191) BY m9a0013g.houston.softwaregrp.com WITH ESMTP; Mon, 6 Apr 2020 08:56:10 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 6 Apr 2020 08:56:10 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.124.72.11) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 6 Apr 2020 08:56:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdNexJaVe8eCxd4mn4nQfUn0MXmSzynUlmRhvC2U1kD55SiUwUzEVTKDzBdm57dE/ZUp0818O4nFHx/2jeYhG1PG1Fy8NVU3AP7Jh7Bd2XMnszBL6pDFFphVx0TZMam2sJeZRJt3+2uk1gEg2Gnwr0w/IAFjuwq6gLsVsykBV4rFuXmALOIlxwuIEkgGOaPjMdL8UgCokpihXYbQ8mUS21xSDCVla+mGgQIbKNeWfNBIinPkfRvPH71KX1eyAPzFFB97KQ4khmqlkUQrL9IVW7k3Of4GXuFtTh4/lQ3BqYcG8H55O8lK9MeyPXXgKO2SMKyQabnrUkSzSugaz+9CBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/zSZKGzo1ESWpKvW7tnwBLjZ/kxuTN44m0Z8TDDDbpQ=; b=bhqZRxUMSq6GfaTnZO5xjOYvvCahPHK9H1aDaff7fiIdlm9uPOznd3puSAO0I5I+pOjFfoSFBLZrxEvA0IfEUmJPk/7eMtaXgE/glf8nNDfNj+MesYlG/eZFojTI8w58yDcvbpERSI9w/T8LFXoz8NwZZ3B96KQUUW5q8NMvhIk36EoZ4e+gUG1+hwRZU0ud5yJQ/gipEmguVJKPojq/MRM5+o9w2jAFGpTkW8ZZ9KfkZkd3mvbSQJxXAv+2y09Z5pe1thdfbqagRMDgsP1XooTQeCeDkPsIG8+7GsPTsXHuN1I1N0NHwimMEcDAZV3oHUSAbftqrl2hszONXyU/eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=MChang@suse.com; Received: from BY5PR18MB3140.namprd18.prod.outlook.com (2603:10b6:a03:1a1::17) by BY5PR18MB3282.namprd18.prod.outlook.com (2603:10b6:a03:1ac::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Mon, 6 Apr 2020 08:56:09 +0000 Received: from BY5PR18MB3140.namprd18.prod.outlook.com ([fe80::a404:f256:fbe8:c2d]) by BY5PR18MB3140.namprd18.prod.outlook.com ([fe80::a404:f256:fbe8:c2d%4]) with mapi id 15.20.2878.018; Mon, 6 Apr 2020 08:56:09 +0000 Date: Mon, 6 Apr 2020 16:55:52 +0800 From: Michael Chang To: Olaf Hering CC: , , Daniel Kiper Subject: Re: [PATCH] cmdline: pass kernel command line as verbatim Message-ID: <20200406085552.GA3819@mercury> References: <20200404053140.10296-1-mchang@suse.com> <20200406091826.33f65f92.olaf@aepfle.de> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200406091826.33f65f92.olaf@aepfle.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: DM6PR12CA0033.namprd12.prod.outlook.com (2603:10b6:5:1c0::46) To BY5PR18MB3140.namprd18.prod.outlook.com (2603:10b6:a03:1a1::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mercury (36.226.140.14) by DM6PR12CA0033.namprd12.prod.outlook.com (2603:10b6:5:1c0::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Mon, 6 Apr 2020 08:56:07 +0000 X-Originating-IP: [36.226.140.14] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d94e5ce-8c3e-4813-2a24-08d7da085959 X-MS-TrafficTypeDiagnostic: BY5PR18MB3282: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-Forefront-PRVS: 0365C0E14B X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR18MB3140.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(52116002)(8936002)(478600001)(86362001)(956004)(5660300002)(33716001)(66476007)(2906002)(66946007)(6916009)(4744005)(316002)(66556008)(9576002)(81166006)(6666004)(6496006)(186003)(26005)(16526019)(1076003)(9686003)(55016002)(4326008)(81156014)(8676002)(33656002); DIR:OUT; SFP:1102; Received-SPF: None (protection.outlook.com: suse.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gUJaD37H5Q1A62SQGcIt47hVyzbl9lnU24E+leJdRef8CNX1qGYSl5qHnOINLb8w/L0+TBOP3Lt4plJIhV/1ijcApbqZ+K1gXmshRppw663rW52gA8AbWn2gc7+08NqhSOzK2TVa30+beCVkRRAaBnVe8PolutCBum1aKgXNOzOTnztaABTBtG4xRi+cmKjg/xLVIyHAgmSTjvvzv/kpsLaeRbESXeKK1eWwrVN+Ha4RGNja0iiV3HYpIKXTfqGzzCr5AIZ0EAG80aBDY35gdhDxPRmQGJts71wxfZIM4150WMxnQHpUxWHeAFahVJQ6pAUjRNleO5YIe4/f32DAqQVdCzgwLFYBTyKYq+7XlyioUJ06zVAzdLRbsrfNAN7m3bgVER86hhhxfglS6Mgbd89vN0qyKvTqJh9MdHvb3TfLWaegK6WQLhMjCUA/P8uJ X-MS-Exchange-AntiSpam-MessageData: K+S6Eua2TwidfhqFGRL9gifFiD9dkD8DNU+eIyVjbIJeEDehiewY/w0R6lpyvuLLqs7Yqh8JAKzpmm2HArsxDiMgv7ccc/u+IzJq59wUyH/eYy1uQhj7bCHaJpt/FaDZoFvyVJAjtMOa8NsDswgm0w== X-MS-Exchange-CrossTenant-Network-Message-Id: 0d94e5ce-8c3e-4813-2a24-08d7da085959 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2020 08:56:09.2122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cMxShRfPaNNmKE7RqRRfpsLlpBAtqc1ql0MwdutKKwwrY9KQqXJ0RPKi+kgxX9Lc X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3282 X-OriginatorOrg: suse.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 15.124.64.91 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 08:57:24 -0000 On Mon, Apr 06, 2020 at 09:18:26AM +0200, Olaf Hering wrote: > Am Sat, 4 Apr 2020 13:31:40 +0800 > schrieb Michael Chang : > > > 7 files changed, 229 insertions(+), 2 deletions(-) > > A lot of churn. It is called 'verbatim', yet it inserts extra characters in the output buffer. What verbatim means when people read that from the manual is really not up to me. Here my attempt was merely to fix problem as you did but mostly reflecting my own point of view. Afterall the table provided in the description can easily be used as reason to turn down the patch if it really not making sense on the premise that we have agreed on a real fix would be looking like, be it yours, mine or anyone else's proposal. > I'm still stunned why there is an argument about the obvious bugfix. It is absolutely bugfix, however any prospective impact on grub.cfg that a bugfix would introduce is always a thing for upstream to adopt it. Thanks, Michael > Good luck. > > Olaf