Content-Type: multipart/mixed; boundary="===============3727605768915146318==" MIME-Version: 1.0 From: Michael S. Tsirkin To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 2/2] vhost: disable for OABI Date: Mon, 06 Apr 2020 09:21:10 -0400 Message-ID: <20200406092056-mutt-send-email-mst@kernel.org> In-Reply-To: List-Id: --===============3727605768915146318== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Apr 06, 2020 at 03:15:20PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin wrot= e: > > > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin = wrote: > > > > > > > > > > > +config VHOST_DPN > > > > + bool "VHOST dependencies" > > > > + depends on !ARM || AEABI > > > > + default y > > > > + help > > > > + Anything selecting VHOST or VHOST_RING must depend on VHO= ST_DPN. > > > > + This excludes the deprecated ARM ABI since that forces a = 4 byte > > > > + alignment on all structs - incompatible with virtio spec = requirements. > > > > + > > > > > > This should not be a user-visible option, so just make this 'def_bool > > > !ARM || AEABI' > > > > > > > I like keeping some kind of hint around for when one tries to understand > > why is a specific symbol visible. > = > I meant you should remove the "VHOST dependencies" prompt, not the > help text, which is certainly useful here. You can also use the three lin= es > = > bool > depends on !ARM || AEABI > default y > = > in front of the help text, but those are equivalent to the one-line versi= on > I suggested. > = > Arnd Oh right. Good point. Thanks! -- = MST --===============3727605768915146318==--