Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACE2C2BA16 for ; Tue, 7 Apr 2020 08:08:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E72D206F7 for ; Tue, 7 Apr 2020 08:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="hO5xZOkO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E72D206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD5C389DBA; Tue, 7 Apr 2020 08:08:56 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F04989DBA for ; Tue, 7 Apr 2020 08:08:55 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id x25so792697wmc.0 for ; Tue, 07 Apr 2020 01:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d7KRz0KTDg48oLgZa5d1A3RRcl9za7nLkIf7O00lbPw=; b=hO5xZOkOTEa17FQaz2R19IJTNHYAptlTxncXvUWzU7UVA1mWMdevbGJqPM6VxiIrrY 8UTrE5tNJmYU0ej6EVbAHmCymU2kykCpUdlheWE10ZznXl/vXMAd8mBZP1Qo3mfmA6wS EC11Q+Zj1A9Lf8MLfrX7tPNdKmBTj2Y9SVxuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d7KRz0KTDg48oLgZa5d1A3RRcl9za7nLkIf7O00lbPw=; b=H7J+udtDyYz3uV1j5NHobZP+5HcqbrL6pWH+H5pRQI5B9zZL9Ql0eu+oVK+a8xsRAn usUkMk5fHqwEZzynVc1uwUwK51iU7MH8LJ2NroPahTiDHCsHSXcisRegUzHn0w0SpQcm nw33gQYWkkfnumvpZJ7sQ61/5u6GqW/Ttob0A4UFOd+XeJmlcryl5l8pMoPacRctOwRS Uv2N1SUNpedmVVKyX4vqFWlQ18kyd9SZDmm3J4nZ41QgRALW9TxRltJV88PKmL0/ndj+ b6l4aQrgnlNMxN97XItNKi1X4dwdFr4JCjkXPqg8/DLZPHo2qKIJOw/eDhyUQRDxa2vO roVg== X-Gm-Message-State: AGi0PuZaU8gmpXS+Q7iPnwUyYB8rh6hNxhwpTgvgFW7vTbI4MY0W0XZZ YEKCFo8RE+Q9JA4SxFOyUqGHQg== X-Google-Smtp-Source: APiQypKpWSewGwKB9P4+a3hN3b/I0Y31w8oPvUUGWjyj4PEzvrPNnoQtvydMRYP+d9riRle7FTL15A== X-Received: by 2002:a1c:f315:: with SMTP id q21mr1080557wmq.169.1586246933988; Tue, 07 Apr 2020 01:08:53 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id 9sm1278026wmm.6.2020.04.07.01.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 01:08:53 -0700 (PDT) Date: Tue, 7 Apr 2020 10:08:51 +0200 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH v2 3/3] drm/writeback: wire drm_writeback.h to kernel-doc Message-ID: <20200407080851.GH3456981@phenom.ffwll.local> References: <20200406194746.26433-1-sam@ravnborg.org> <20200406194746.26433-4-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406194746.26433-4-sam@ravnborg.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , David Airlie , Daniel Vetter , Liviu Dudau , dri-devel@lists.freedesktop.org, Thomas Zimmermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 06, 2020 at 09:47:46PM +0200, Sam Ravnborg wrote: > drm_writeback.h included a lot of nice kernel-doc comments. > Wire it up so the header file is included in the kernel-doc > generated documentation. > > Added a few simple comments to the two structs so they > get picked up by kernel-doc. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Brian Starkey > Cc: Liviu Dudau > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Maxime Ripard > Cc: Maxime Ripard Reviewed-by: Daniel Vetter > --- > Documentation/gpu/drm-kms.rst | 3 +++ > include/drm/drm_writeback.h | 9 +++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > index e1f685015807..397314d08f77 100644 > --- a/Documentation/gpu/drm-kms.rst > +++ b/Documentation/gpu/drm-kms.rst > @@ -397,6 +397,9 @@ Connector Functions Reference > Writeback Connectors > -------------------- > > +.. kernel-doc:: include/drm/drm_writeback.h > + :internal: > + > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > :doc: overview > > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h > index 777c14c847f0..9697d2714d2a 100644 > --- a/include/drm/drm_writeback.h > +++ b/include/drm/drm_writeback.h > @@ -15,7 +15,13 @@ > #include > #include > > +/** > + * struct drm_writeback_connector - DRM writeback connector > + */ > struct drm_writeback_connector { > + /** > + * @base: base drm_connector object > + */ > struct drm_connector base; > > /** > @@ -78,6 +84,9 @@ struct drm_writeback_connector { > char timeline_name[32]; > }; > > +/** > + * struct drm_writeback_job - DRM writeback job > + */ > struct drm_writeback_job { > /** > * @connector: > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel