From: Wolfgang Denk Date: Tue, 07 Apr 2020 18:28:47 +0200 Subject: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment In-Reply-To: <8607d1778bcd4035807908e4a3a90381@SFHDAG6NODE3.st.com> References: <20200331180330.1.Ied6708bad5048382a57618f95d67c549aae49f42@changeid> <20200331160456.26254-1-patrick.delaunay@st.com> <20200401112615.931A024003E@gemini.denx.de> <8607d1778bcd4035807908e4a3a90381@SFHDAG6NODE3.st.com> Message-ID: <20200407162847.8884D24003E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Patrick, In message <8607d1778bcd4035807908e4a3a90381@SFHDAG6NODE3.st.com> you wrote: > > To simplify the test: > > env_check = " if env info -p -d -q; then env save; fi;" All such automatical "env save" actions somewhere in the code give me the creeps. I've seen too often that they did things I nver intended to do or would have accepted if I had a chance to decide. Use extremely careful, please. From a user point of view, it's me who owns the environment, and nobody should mess with my data without me confirming it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Well I don't see why I have to make one man miserable when I can make so many men happy." - Ellyn Mustard, about marriage