Content-Type: multipart/mixed; boundary="===============8852779647693899667==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [RFC PATCH 15/34] iommu/amd: Convert to probe/release_device() call-backs Date: Thu, 09 Apr 2020 06:52:11 +0800 Message-ID: <202004090623.W8dsc7mt%lkp@intel.com> In-Reply-To: <20200407183742.4344-16-joro@8bytes.org> List-Id: --===============8852779647693899667== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Joerg, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on iommu/next] [also build test WARNING on next-20200408] [cannot apply to tegra/for-next rockchip/for-next arm-perf/for-next/perf v5= .6] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-io= mmu_group-setup-to-IOMMU-core-code/20200408-035703 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot cppcheck warnings: (new ones prefixed by >>) drivers/iommu/amd_iommu.c:298:9: warning: The scope of the variable 'pos= ' can be reduced. [variableScope] int i, pos; ^ drivers/iommu/amd_iommu.c:1656:7: warning: The scope of the variable 'pt= e' can be reduced. [variableScope] u64 *pte; ^ drivers/iommu/amd_iommu.c:2294:25: warning: The scope of the variable 'e= ntry' can be reduced. [variableScope] struct iommu_dev_data *entry; ^ drivers/iommu/amd_iommu.c:2869:6: warning: The scope of the variable 'in= dex' can be reduced. [variableScope] int index; ^ drivers/iommu/amd_iommu.c:2981:23: warning: The scope of the variable 'i= o_domain' can be reduced. [variableScope] struct iommu_domain *io_domain; ^ drivers/iommu/amd_iommu.c:3023:6: warning: The scope of the variable 'ma= x_pasids' can be reduced. [variableScope] int max_pasids; ^ drivers/iommu/amd_iommu.c:318:43: warning: Clarify calculation precedenc= e for '&' and '?'. [clarifyCalculation] return dev_data->errata & (1 << erratum) ? true : false; ^ >> drivers/iommu/amd_iommu.c:407:8: warning: Variable 'iommu' is assigned a= value that is never used. [unreadVariable] iommu =3D amd_iommu_rlookup_table[devid]; ^ drivers/iommu/amd_iommu.c:3507:20: warning: The scope of the variable 'i= ommu' can be reduced. [variableScope] struct amd_iommu *iommu; ^ drivers/iommu/amd_iommu.c:3660:21: warning: The scope of the variable 'i= ommu' can be reduced. [variableScope] struct amd_iommu *iommu; ^ vim +/iommu +407 drivers/iommu/amd_iommu.c 26018874e3584f arch/x86/kernel/amd_iommu.c Joerg Roedel 2011-06-06 396 = 00d947164c394f drivers/iommu/amd_iommu.c Joerg Roedel 2020-04-07 397 = static void amd_iommu_uninit_device(struct device *dev) 657cbb6b6cba0f arch/x86/kernel/amd_iommu.c Joerg Roedel 2009-11-23 398 = { 7aba6cb9ee9db7 drivers/iommu/amd_iommu.c Wan Zongshun 2016-04-01 399 = struct iommu_dev_data *dev_data; 39ab9555c24110 drivers/iommu/amd_iommu.c Joerg Roedel 2017-02-01 400 = struct amd_iommu *iommu; 39ab9555c24110 drivers/iommu/amd_iommu.c Joerg Roedel 2017-02-01 401 = int devid; c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 402 = 7aba6cb9ee9db7 drivers/iommu/amd_iommu.c Wan Zongshun 2016-04-01 403 = devid =3D get_device_id(dev); 9ee35e4c6f42e7 drivers/iommu/amd_iommu.c Joerg Roedel 2016-04-21 404 = if (devid < 0) 7aba6cb9ee9db7 drivers/iommu/amd_iommu.c Wan Zongshun 2016-04-01 405 = return; c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 406 = 39ab9555c24110 drivers/iommu/amd_iommu.c Joerg Roedel 2017-02-01 @407 = iommu =3D amd_iommu_rlookup_table[devid]; 39ab9555c24110 drivers/iommu/amd_iommu.c Joerg Roedel 2017-02-01 408 = 7aba6cb9ee9db7 drivers/iommu/amd_iommu.c Wan Zongshun 2016-04-01 409 = dev_data =3D search_dev_data(devid); c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 410 = if (!dev_data) c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 411 = return; c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 412 = b6809ee573cc2f drivers/iommu/amd_iommu.c Joerg Roedel 2016-02-26 413 = if (dev_data->domain) b6809ee573cc2f drivers/iommu/amd_iommu.c Joerg Roedel 2016-02-26 414 = detach_device(dev); b6809ee573cc2f drivers/iommu/amd_iommu.c Joerg Roedel 2016-02-26 415 = 8fa5f802abf3cd arch/x86/kernel/amd_iommu.c Joerg Roedel 2011-06-09 416 = /* c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 417 = * We keep dev_data around for unplugged devices and reuse it when the c1931090a22b96 drivers/iommu/amd_iommu.c Alex Williamson 2014-07-03 418 = * device is re-plugged - not doing so would introduce a ton of races. 8fa5f802abf3cd arch/x86/kernel/amd_iommu.c Joerg Roedel 2011-06-09 419 = */ 657cbb6b6cba0f arch/x86/kernel/amd_iommu.c Joerg Roedel 2009-11-23 420 = } b7cc9554bc7364 arch/x86/kernel/amd_iommu.c Joerg Roedel 2009-12-10 421 = :::::: The code at line 407 was first introduced by commit :::::: 39ab9555c24110671f8dc671311a26e5c985b592 iommu: Add sysfs bindings f= or struct iommu_device :::::: TO: Joerg Roedel :::::: CC: Joerg Roedel --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8852779647693899667==--