Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C15C2BBC7 for ; Sat, 11 Apr 2020 23:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9419D2173E for ; Sat, 11 Apr 2020 23:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646476; bh=VY+srS1QB5ufiWNW88+dyuoRCUoCCbimxVHPK1bPttU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yTkw9avOMYLyl96yhwMlcuCaiDcJpGTyHJB8/JUArGboZcz5g4C8G6lE9wwHD/ZcX 6YfcLWVXlx+ppp+9kSlkKVVQ9iU9GZOXjMMQb9cL1E77wldW2S84c2JCS63dA81jY3 c1F2lMw/j+U3I/InfG2e99dmDSLqQRr2ajBthpgI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbgDKXHz (ORCPT ); Sat, 11 Apr 2020 19:07:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728768AbgDKXHx (ORCPT ); Sat, 11 Apr 2020 19:07:53 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4630D21841; Sat, 11 Apr 2020 23:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646474; bh=VY+srS1QB5ufiWNW88+dyuoRCUoCCbimxVHPK1bPttU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FtnFwGh0RP7zFGfT+EiJE4+MCxboZsbPoRhPXWXenXotEZ6TsDe/S2MwCIpxDCctm N7McJYGO2dNw0GISEuQQfFxxEwofPzzanDiIHz069DKfCKe10k2DdJv+k2z/gqGQo2 7juE1QP6TlZjyyIqhsw9zdMfXg1fcbbomsHaFiGs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guangbin Huang , Huazhong Tan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 040/121] net: hns3: modify an unsuitable print when setting unknown duplex to fibre Date: Sat, 11 Apr 2020 19:05:45 -0400 Message-Id: <20200411230706.23855-40-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230706.23855-1-sashal@kernel.org> References: <20200411230706.23855-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Guangbin Huang [ Upstream commit 2d3db26d78805c9e06e26def0081c76e9bb0b7d6 ] Currently, if device is in link down status and user uses 'ethtool -s' command to set speed but not specify duplex mode, the duplex mode passed from ethtool to driver is unknown value(255), and the fibre port will identify this value as half duplex mode and print "only copper port supports half duplex!". This message is confusing. So for fibre port, only the setting duplex is half, prints error and returns. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c index 6e0212b79438a..4c411ba062fb9 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c @@ -737,7 +737,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev, if (ops->get_media_type) ops->get_media_type(handle, &media_type, &module_type); - if (cmd->base.duplex != DUPLEX_FULL && + if (cmd->base.duplex == DUPLEX_HALF && media_type != HNAE3_MEDIA_TYPE_COPPER) { netdev_err(netdev, "only copper port supports half duplex!"); -- 2.20.1