From: Mark Brown Subject: Re: [PATCH v2 10/16] gpio: add a reusable generic gpio_chip using regmap Date: Tue, 14 Apr 2020 19:39:21 +0100 Message-ID: <20200414183921.GN5412@sirena.org.uk> References: <20200402203656.27047-1-michael@walle.cc> <20200402203656.27047-11-michael@walle.cc> <80bd8661ec8a1f5eda3f09a267846eaa@walle.cc> <20200414172129.GJ5412@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uWbmMdDzzl2TXAgx" Return-path: Received: from mail.kernel.org ([198.145.29.99]:33860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504116AbgDNSjY (ORCPT ); Tue, 14 Apr 2020 14:39:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Michael Walle Cc: Bartosz Golaszewski , linux-gpio , linux-devicetree , LKML , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , arm-soc , Linus Walleij , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner --uWbmMdDzzl2TXAgx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 14, 2020 at 08:36:23PM +0200, Michael Walle wrote: > Am 2020-04-14 19:21, schrieb Mark Brown: > > You could define REGMAP_INVALID_ADDR to be (unsigned int)(-1) or some > > other suitably implausible address and use that as a value. It's > > possible that there might be a collision with a real address on some > > device but it should be sufficiently unlikely to be useful, especially > > if it's not something regmap in general goes and evaluates. For extra > > safety we could have an API for allowing users to query the register > > validity information regmap has (or can be given) and gpiolib could then > > use that to figure out if the value was actually a dummy value but > > that's probably overdoing it. > If possible, I'd like to have the opposite logic. That is, if it is not > set it should be invalid. If we have a magic macro like > REGMAP_INVALID_ADDR, we must assign it to all the unused addresses. Thus > every driver would have to assign all addresses and if in the future > there will be some added, we'd have to touch all the drivers which use > gpio_regmap. Sure, for that you'd need a separate flag since zero is such a commonly valid address. --uWbmMdDzzl2TXAgx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6WA1gACgkQJNaLcl1U h9BAjwf/bIsieXPSNQdoyPsGYQ4OjkmRX200mVnxW9V8WW1aT87hmD5XwdcUz27T 0oXCpdsy7VDE5l4T7iDCXzXW1++aQW/mOE7MW7fgfDLWe212XUBcKluVTQ77+1wo z8FEPPjTRReUzy4LyvEtOuPv8S/wEeHOaPxuyOhhNacw5Sa/Wrmoj3UJRsUzB/MG Cm0W3nRmAIw1VeyMwP89BNeTXYdbqUojlBRj5DZRhXziF7L6YyLe8nMH3ZN+JOq7 Od3cD4VROPQ3xfDaeCEG8QsoHSwZXYG+2kF7DjgWvC7zliuISkElPje0uK2KEHHJ aaGR4e5qeBL5Nha6oy2QwhRMN1Fezw== =I4w+ -----END PGP SIGNATURE----- --uWbmMdDzzl2TXAgx--