Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDB3C2BA19 for ; Wed, 15 Apr 2020 11:17:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FB052074F for ; Wed, 15 Apr 2020 11:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="2VH5qIq6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FB052074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOg29-0007PO-Di; Wed, 15 Apr 2020 11:16:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOg28-0007PG-5u for xen-devel@lists.xenproject.org; Wed, 15 Apr 2020 11:16:44 +0000 X-Inumbo-ID: 965ad9e2-7f0a-11ea-b58d-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 965ad9e2-7f0a-11ea-b58d-bc764e2007e4; Wed, 15 Apr 2020 11:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BgC3RHuuwyz8SKjiEeETpqmeE62rDCI7wOFjpCWjtDc=; b=2VH5qIq61mB6KEOWfrmc4qQ6la r5CC4xxULrTdM2unC4POPo13AVeSxJYXN3/9oSvWKKgX7hZg3ew/1Uvu3PM3zFArYsAg/vg1+ITWG 4U8tIUzehCYbvsbAgJ6mH/F6FWSqTL5PmD57F9uCsymAFMl2GfEJyCMkODWwJUd5gj9I=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOg27-0001Lf-AN; Wed, 15 Apr 2020 11:16:43 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jOg27-0005dD-1X; Wed, 15 Apr 2020 11:16:43 +0000 Date: Wed, 15 Apr 2020 12:16:40 +0100 From: Wei Liu To: Roger Pau Monne Subject: Re: [PATCH] x86/altp2m: add missing break Message-ID: <20200415111640.lbtoajlrhxyoffsz@debian> References: <20200415110939.9481-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200415110939.9481-1-roger.pau@citrix.com> User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Wei Liu , Jan Beulich , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, Apr 15, 2020 at 01:09:39PM +0200, Roger Pau Monne wrote: > Add a missing break in the HVMOP_altp2m_set_visibility case, or else > code flow will continue into the default case and trigger the assert. > > Fixes: 3fd3e9303ec4b1 ('x86/altp2m: hypercall to set altp2m view visibility') > Coverity-ID: 1461759 > Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu