IronPort-SDR: Tgj+7IgukCttv4C+edDJON8ookhvKM72zcyvJAURrO3heTexrjSHPvQc9fmlKT0S/ESm6CNDca
 GcVc2GWF34FQ==
IronPort-SDR: 2+RGo6PUMlKtNAedTTXIlMRJTZel4PZ+T+0h0JtYaBewn4luM5ogyrmn6wfHaGyJ3VvO98SE1e
 Tc2fvhVcDbag==
Date:   Wed, 15 Apr 2020 15:33:41 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Serge Semin <fancer.lancer@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 03/13] gpio: dwapb: set default handler to be
 handle_bad_irq()
Message-ID: <20200415123341.GC185537@smile.fi.intel.com>
References: <20200409141228.49561-1-andriy.shevchenko@linux.intel.com>
 <20200409141228.49561-4-andriy.shevchenko@linux.intel.com>
 <20200415122208.wp7ah6nxwhph4wi5@mobilestation>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200415122208.wp7ah6nxwhph4wi5@mobilestation>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 15, 2020 at 03:22:08PM +0300, Serge Semin wrote:
> On Thu, Apr 09, 2020 at 05:12:18PM +0300, Andy Shevchenko wrote:
> > We switch the default handler to be handle_bad_irq() instead of
> > handle_level_irq(), though for now apply it later in the code,
> > to make the difference between IRQ chips more visible.
> 
> s/IRQ chips/IRQ types ?

Actually IRQ chips. The code instantiates two IRQ chips.

> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

Thanks!

> Note though I'd better refactored the whole dwapb_configure_irqs()
> method with using GPIOlib irqchip API, which is preferred by the current
> GPIO subsystem. This isn't a subject for this series. Just to note, that
> such change is very actual.

I know, but it's indeed out of scope of this series.

-- 
With Best Regards,
Andy Shevchenko