Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F106EC2BA19 for ; Wed, 15 Apr 2020 14:49:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE27120767 for ; Wed, 15 Apr 2020 14:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="J5/v1d/5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE27120767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOjLr-000461-9I; Wed, 15 Apr 2020 14:49:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOjLp-00045H-6E for xen-devel@lists.xenproject.org; Wed, 15 Apr 2020 14:49:17 +0000 X-Inumbo-ID: 470f657e-7f28-11ea-8a71-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 470f657e-7f28-11ea-8a71-12813bfff9fa; Wed, 15 Apr 2020 14:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1586962156; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=s3ICpc1EDdmLld+0LjoYXrjTWGZGplxJRqBfFexohwI=; b=J5/v1d/5rzH12WxrmO1A/a74FRxryRTigeBKpASi5QVBjiHDemR0moJr iiWg3qUibCcV1n2/6nnyFi8OIQwSjI5P1nh6bNSfDTu8I3C0LEy5jTMoW G3ubrvyvBA3xe2VPdY0aj7r3tlK/0/xHbb91WO5+QISvQAB1etXKe1p77 g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: tZKaEua7vsq1lQnBeUkT/NzXPXR5ffIeaHTOTCx4uqvGDT8hCaEzO1eFSnenmiDZdvNa0rDIVG HR6RUFRwpdJns4Zue2S6/IPVaSb5d3e+FOHf4Vbv4pgUSXv3FucLTlinYSSYlbVKcNVw4cxcRX mPrvGbUG6nmHGALwk12LJ8RVTG7I1dBEZ1t4RsEwN1X1CuQYzpMXdtca7ds0RKu4cNWwnTv+Qa qpyPp2rOU2HWkxryYDU2jZ+K35fqCgKYU5uUbbD9a7WbLd0kwzx24SERzMGDntiuhHFJE6p5iC LeE= X-SBRS: 2.7 X-MesageID: 15704956 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,387,1580792400"; d="scan'208";a="15704956" Date: Wed, 15 Apr 2020 16:49:08 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH v9 1/3] x86/tlb: introduce a flush HVM ASIDs flag Message-ID: <20200415144908.GM28601@Air-de-Roger> References: <20200406105703.79201-2-roger.pau@citrix.com> <30062a0c-6587-a16e-2b31-de0dd6bf4c9a@suse.com> <20200414075245.GC28601@Air-de-Roger> <92a4ff05-9dcf-1d50-b9b2-bde39c4e3e8d@suse.com> <20200414100213.GH28601@Air-de-Roger> <389afe02-1747-1583-e642-6e4025b402aa@suse.com> <20200414111911.GI28601@Air-de-Roger> <073512c9-6500-054c-c72c-1f468da6464c@suse.com> <20200414145337.GJ28601@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Tim Deegan , George Dunlap , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Apr 14, 2020 at 05:06:23PM +0200, Jan Beulich wrote: > On 14.04.2020 16:53, Roger Pau Monné wrote: > > On Tue, Apr 14, 2020 at 03:50:15PM +0200, Jan Beulich wrote: > >> On 14.04.2020 13:19, Roger Pau Monné wrote: > >>> On Tue, Apr 14, 2020 at 12:13:04PM +0200, Jan Beulich wrote: > >>>> On 14.04.2020 12:02, Roger Pau Monné wrote: > >>>>> That seems nice, we would have to be careful however as reducing the > >>>>> number of ASID/VPID flushes could uncover issues in the existing code. > >>>>> I guess you mean something like: > >>>>> > >>>>> static inline void guest_flush_tlb_mask(const struct domain *d, > >>>>> const cpumask_t *mask) > >>>>> { > >>>>> flush_mask(mask, (is_pv_domain(d) || shadow_mode_enabled(d) ? FLUSH_TLB > >>>>> : 0) | > >>>>> (is_hvm_domain(d) && cpu_has_svm ? FLUSH_HVM_ASID_CORE > >>>>> : 0)); > >>>>> } > >>>> > >>>> Almost - is_hvm_domain(d) && cpu_has_svm seems to wide for me. I'd > >>>> rather use hap_enabled() && cpu_has_svm, which effectively means NPT. > >>>> Or am I overlooking a need to do ASID flushes also in shadow mode? > >>> > >>> I think so, I've used is_hvm_domain in order to cover for HVM domains > >>> running in shadow mode on AMD hardware, I think those also need the > >>> ASID flushes. > >> > >> I'm unconvinced: The entire section "TLB Management" in the PM gives > >> the impression that "ordinary" TLB flushing covers all ASIDs anyway. > >> It's not stated anywhere (I could find) explicitly though. > > > > Hm, I don't think so. XenRT found a myriad of issues with NPT when p2m > > code wasn't modified to do ASID flushes instead of plain TLB flushes. > > Well, that's clear from e.g. p2m_pt_set_entry() not doing any > flushing itself. > > > Even if it's just to stay on the safe side I would perform ASID > > flushes for HVM guests with shadow running on AMD. > > Tim, any chance you could voice your thoughts here? To me it seems > odd to do an all-ASIDs flush followed by an ASID one. I've been reading a bit more into this, and section 15.16.1 states: "TLB flush operations must not be assumed to affect all ASIDs." Since the VMM runs on it's own ASID it's my understanding that doing a TLB flush from the VMM does not flush any of the guests TLBs, and hence an ASID flush is still required. Thanks, Roger.