Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3C5C2BA19 for ; Wed, 15 Apr 2020 08:23:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12A4C2078A for ; Wed, 15 Apr 2020 08:23:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vGM9sA8D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12A4C2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1FB76E913; Wed, 15 Apr 2020 08:23:39 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E18C6E913 for ; Wed, 15 Apr 2020 08:23:38 +0000 (UTC) Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 803C520784; Wed, 15 Apr 2020 08:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586939018; bh=0kpxY7WRGFbm5Qwfk/sr8dvg3Yio8hbJ+U8aY4ogpnA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vGM9sA8DLqJS/QtEocHEqn/OvB/TI8TVm/SPdYRlIaKnHqtE4vOYZjexduuu5974c hrpTnb4L2dDtN9i58/NQOYkv28mC7SPW0RuV8+EGtecJ3NngVYWdwaUqcYn8W2m3+S 2bvaxNKzZCBZfN/N9RLXRcbMvBWXMf7Jly+QPEa0= Date: Wed, 15 Apr 2020 17:23:31 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Subject: Re: [PATCH v3] x86: insn: Add insn_is_fpu() Message-Id: <20200415172331.96807c231956f3a7255b0202@kernel.org> In-Reply-To: <158648174982.1073.6608148826246795028.stgit@devnote2> References: <20200409143212.GW20696@hirez.programming.kicks-ass.net> <158648174982.1073.6608148826246795028.stgit@devnote2> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Zhou , Josh Poimboeuf , Jann Horn , Peter Zijlstra , the arch/x86 maintainers , kernel list , amd-gfx@lists.freedesktop.org, Leo Li , Ingo Molnar , Borislav Petkov , Arnaldo Carvalho de Melo , Andy Lutomirski , "H . Peter Anvin" , Alex Deucher , Thomas Gleixner , Harry Wentland , Christian =?UTF-8?B?S8O2bmln?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, 10 Apr 2020 10:22:30 +0900 Masami Hiramatsu wrote: > @@ -318,10 +331,14 @@ function convert_operands(count,opnd, i,j,imm,mod) > if (match(opcode, rex_expr)) > flags = add_flags(flags, "INAT_MAKE_PREFIX(INAT_PFX_REX)") > > - # check coprocessor escape : TODO > - if (match(opcode, fpu_expr)) > + # x87 escape opcode needs MODRM > + if (match(ext, x87_expr)) Oops, it must be match(opcode, x87_expr). I'll fix it. Thanks, -- Masami Hiramatsu _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx