From: Andrew Lunn Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Date: Thu, 16 Apr 2020 16:42:31 +0200 Message-ID: <20200416144231.GP657811@lunn.ch> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:41836 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394496AbgDPOmi (ORCPT ); Thu, 16 Apr 2020 10:42:38 -0400 Content-Disposition: inline In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Robin Murphy Cc: Linus Walleij , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , "open list:GPIO SUBSYSTEM" , Gregory Clement , Russell King - ARM Linux admin , linux-pwm@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Linux ARM , Sebastian Hesselbarth On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Hi Robin It is not really hope. It is very obvious when it is wrong, the whole machine stops dead when you are missing a clock. Very simple to test. Andrew