From: Tom Rini Date: Thu, 16 Apr 2020 13:04:15 -0400 Subject: [PATCH 2/5] lib: date functions in SPL In-Reply-To: <8d728917-39e1-616d-cc48-23a657c23262@gmx.de> References: <20200415164623.142908-1-xypron.glpk@gmx.de> <20200415164623.142908-3-xypron.glpk@gmx.de> <20200416023217.GK12111@bill-the-cat> <8d728917-39e1-616d-cc48-23a657c23262@gmx.de> Message-ID: <20200416170415.GV12111@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Apr 16, 2020 at 06:30:48PM +0200, Heinrich Schuchardt wrote: > On 4/16/20 4:32 AM, Tom Rini wrote: > > On Wed, Apr 15, 2020 at 06:46:20PM +0200, Heinrich Schuchardt wrote: > > > >> Date functions are only needed in SPL if SPL contains RTC drivers. > >> > >> Fixes: 05429b6cf5b3 ("rtc: move date.c from drivers/rtc/ to lib/") > >> Signed-off-by: Heinrich Schuchardt > > > > Does this show up as a problem somewhere? I don't see this resulting in > > size savings anywhere, thanks. > > > > We are compiling ./spl/lib/date.o for no good reason since said patch. > It may be that the when creating u-boot-spl.bin from u-boot-spl this > gets deleted again due to linker optimization. It is discarded at link time, yes. I'm generally dis-inclined to grab patches like this when it adds more to the Makefile without a size savings. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: