Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42443C2BA19 for ; Sat, 18 Apr 2020 09:03:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13183206D6 for ; Sat, 18 Apr 2020 09:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13183206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPjNh-0004PI-Mj; Sat, 18 Apr 2020 09:03:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPjNf-0004PD-HA for xen-devel@lists.xenproject.org; Sat, 18 Apr 2020 09:03:19 +0000 X-Inumbo-ID: 720ae38e-8153-11ea-b58d-bc764e2007e4 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 720ae38e-8153-11ea-b58d-bc764e2007e4; Sat, 18 Apr 2020 09:03:18 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1jPjNd-000O9E-9K; Sat, 18 Apr 2020 09:03:17 +0000 Date: Sat, 18 Apr 2020 10:03:17 +0100 From: Tim Deegan To: Jan Beulich Subject: Re: [PATCH 07/10] x86/shadow: the guess_wrmap() hook is needed for HVM only Message-ID: <20200418090317.GD92478@deinos.phlegethon.org> References: <65bfcd6a-2bb0-da6f-9e85-39f224bd81fb@suse.com> <1e221192-7899-b60d-0280-b77ab5877772@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1e221192-7899-b60d-0280-b77ab5877772@suse.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" At 16:28 +0200 on 17 Apr (1587140897), Jan Beulich wrote: > sh_remove_write_access() bails early for !external guests, and hence its > building and thus the need for the hook can be suppressed altogether in > !HVM configs. > > Signed-off-by: Jan Beulich > @@ -366,6 +367,14 @@ int sh_validate_guest_entry(struct vcpu > extern int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn, > unsigned int level, > unsigned long fault_addr); > +#else > +static inline int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn, > + unsigned int level, > + unsigned long fault_addr) > +{ Can we have an ASSERT(!shadow_mode_refcounts(d)) here, please, matching the check that would have made it a noop before? Cheers, Tim.