From: Greg Kroah-Hartman Date: Sun, 19 Apr 2020 06:04:04 +0000 Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c Message-Id: <20200419060404.GB3535909@kroah.com> List-Id: References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-8-rdunlap@infradead.org> <20200419060247.GA3535909@kroah.com> In-Reply-To: <20200419060247.GA3535909@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Randy Dunlap Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , linux-kernel@vger.kernel.org, "J. Bruce Fields" , target-devel@vger.kernel.org, Dave Jiang , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , linux-nfs@vger.kernel.org, "Martin K. Petersen" , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel@vger.kernel.org, Johannes Berg , Linus Torvalds On Sun, Apr 19, 2020 at 08:02:47AM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote: > > Fix gcc empty-body warning when -Wextra is used: > > > > ../drivers/base/devcoredump.c:297:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > ../drivers/base/devcoredump.c:301:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > > > Signed-off-by: Randy Dunlap > > Cc: Johannes Berg > > Cc: Linus Torvalds > > Cc: Andrew Morton > > --- > > drivers/base/devcoredump.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > --- linux-next-20200417.orig/drivers/base/devcoredump.c > > +++ linux-next-20200417/drivers/base/devcoredump.c > > @@ -9,6 +9,7 @@ > > * > > * Author: Johannes Berg > > */ > > +#include > > Why the need for this .h file being added for reformatting the code? Ah, the function you add, nevermind, need more coffee...