Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE6BC3815B for ; Mon, 20 Apr 2020 06:08:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F18A0206F6 for ; Mon, 20 Apr 2020 06:08:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BXq7CB7I"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mh7u/Nzr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F18A0206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=H7rody0xWmIuZEyNLNLWhGMNrfJ8A0q37sqw+WIMmAQ=; b=BXq7CB7IwB+rRO Ngh8HD9mjUeuoocSm7nVPOaltJ+C1rTMxkGvBvyRxKrMqKnVFIOO9nc0BfUkqF/pndEfoyqs1aOwf NfQ+Jh+dXOAtflK6RVqsLE1UIb8UhPK+5T3w8DsJK31LTCHM0hSqAUZQUpsBYHgdbFSXS3RbVHgPN 5Al3JEN+F2pfmMygbpOgdQkR6FXKUjxDG//4O8WZL6OgbgO+010KZy8DLWjyUAsSrwIqrY0MvqKHE 9JG6imluH+sCGMhjOuqp/VbHfCmQ+60xt+sY8YxfpnmnzI6DSG3gUBvRBV9rudt+gUovwzW8M7vue jnpXbcCGyPlR3WM29M2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQPbv-0000py-O9; Mon, 20 Apr 2020 06:08:51 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQPbq-0000oj-DW for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 06:08:50 +0000 Received: by mail-pl1-x643.google.com with SMTP id f8so3571935plt.2 for ; Sun, 19 Apr 2020 23:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SezQvaqjYLbKiOOQWAcX/3BNfbHbuPlMP92AcIlOvpA=; b=mh7u/Nzr3V0kjSRxTO0mKkatpJU809OLSLJJlsFt2qqISf72DiGj5xWDQAEvljElfV FeYKApqTjmmOh8eLf4oP5EPyFuKRdTWijq0Bt4MVVh7MOdqoryB1MbCic8WbRgfkq6eg E9a9BiB+TFtHM9d/GUjKY4K1Jx3aDv8xSb9Lk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SezQvaqjYLbKiOOQWAcX/3BNfbHbuPlMP92AcIlOvpA=; b=UwJqZbuS3pYOKYxStDU59eukYt1ONICioREVraMCuzyVGbbtvI4AA5s3OSJ2LZM1sm 3ataFSCQwnjO/0QsI0AYznuPkR0nMVOqAymJBC9od//rkJL/dzaonrLGXWNtE029sSK0 qjPAY2LxWumme0Vzoh61uB7McAyk6vWbHxrXmxPiR048b4gp5htDH3YYXSojT36CWKMR +7uSrsIIAeffEQe9PwUhMbYWPEbi4LmFfikPRMqd4MR+rgVCr1lVxPmzMEDPsijfOp59 QgCguGLW/TKuL/7FT5FhESS5JZKs1rmmQBpcA1VBM/u4qBbDPN2oXybaCk2xlmBEL14a 2IAA== X-Gm-Message-State: AGi0PuYinRpeAoYzhGu+/pJ/tn9gQLA90DIvOL/qYy6mvSRdKK+xOA/Q votiXR4iEIl9jO7Fd+/K1uwqIg== X-Google-Smtp-Source: APiQypJ7/kohKua8cbRIlf5c1h2ySfX9UyLVzIyb/i9csqaqSHKdHfXhwGV1/987z+JuCjIkPug5+Q== X-Received: by 2002:a17:90a:340c:: with SMTP id o12mr20794100pjb.22.1587362925217; Sun, 19 Apr 2020 23:08:45 -0700 (PDT) Received: from localhost ([2401:fa00:9:14:a274:40bd:f640:b6c6]) by smtp.gmail.com with ESMTPSA id t188sm21384pfb.102.2020.04.19.23.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 23:08:44 -0700 (PDT) From: Anand K Mistry X-Google-Original-From: Anand K Mistry To: linux-mediatek@lists.infradead.org Subject: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0 Date: Mon, 20 Apr 2020 16:08:34 +1000 Message-Id: <20200420060834.44461-1-amistry@google.com> X-Mailer: git-send-email 2.26.1.301.g55bc3eb7cb9-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200419_230846_480105_810FB955 X-CRM114-Status: UNSURE ( 9.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: matthias.bgg@gmail.com, ck.hu@mediatek.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Anand K Mistry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org If dma_map_sg() merges pages when creating the mapping, only the first entries will have a valid sg_dma_address() and sg_dma_len(), followed by entries with sg_dma_len() == 0. Signed-off-by: Anand K Mistry --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c index b04a3c2b111e09..f8fd8b98c30e3d 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -224,6 +224,9 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, expected = sg_dma_address(sg->sgl); for_each_sg(sg->sgl, s, sg->nents, i) { + if (!sg_dma_len(s)) + break; + if (sg_dma_address(s) != expected) { DRM_ERROR("sg_table is not contiguous"); ret = -EINVAL; -- 2.26.1.301.g55bc3eb7cb9-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel