Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2855C3815B for ; Mon, 20 Apr 2020 13:03:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8635206DD for ; Mon, 20 Apr 2020 13:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="CeR48/NO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8635206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQW4j-0005tl-3v; Mon, 20 Apr 2020 13:03:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQW4h-0005tg-Tf for xen-devel@lists.xenproject.org; Mon, 20 Apr 2020 13:02:59 +0000 X-Inumbo-ID: 428a1304-8307-11ea-9e09-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 428a1304-8307-11ea-9e09-bc764e2007e4; Mon, 20 Apr 2020 13:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=W09ujvn6zHL+FVq+uHtKF1npnXqYeIi9IbSgfmvfBWY=; b=CeR48/NOEPi4RpjQw2iSDQcS4v 65xLdBQM0XmIJFbFA8+XilT7ueqfUYseGW/2Uz39w1HHy/FjEDzCiuEoOyvFFVGmivi6/LjopUUn5 Qe7kSUnS90FrzAki5NiaAAjsUWpFznu+fQ8Ppr7v+HtLkexMPDrewJ6k4a5S5cv01FZQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQW4f-0004iA-L6; Mon, 20 Apr 2020 13:02:57 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jQW4f-0003jR-Ac; Mon, 20 Apr 2020 13:02:57 +0000 Date: Mon, 20 Apr 2020 14:02:54 +0100 From: Wei Liu To: Jan Beulich Subject: Re: [PATCH v3] Introduce a description of the Backport and Fixes tags Message-ID: <20200420130254.unwgbelql75lnprw@debian> References: <20200417222430.20480-1-sstabellini@kernel.org> <35b34e2f-e6cd-6afc-19fd-c7880ec0eace@xen.org> <20200420102710.cg3bmjlntgpxqj77@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: lars.kurth@citrix.com, Stefano Stabellini , Julien Grall , Wei Liu , konrad.wilk@oracle.com, andrew.cooper3@citrix.com, Ian Jackson , george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Apr 20, 2020 at 02:36:49PM +0200, Jan Beulich wrote: > On 20.04.2020 12:27, Wei Liu wrote: > > On Mon, Apr 20, 2020 at 10:31:28AM +0100, Julien Grall wrote: > >> On 17/04/2020 23:24, Stefano Stabellini wrote: > >>> Create a new document under docs/process to describe our special tags. > >>> Add a description of the Fixes tag and the new Backport tag. Also > >>> clarify that lines with tags should not be split. > >>> > >>> Signed-off-by: Stefano Stabellini > >>> CC: Ian Jackson > >>> CC: Wei Liu > >>> CC: jbeulich@suse.com > >>> CC: george.dunlap@citrix.com > >>> CC: julien@xen.org > >>> CC: lars.kurth@citrix.com > >>> CC: andrew.cooper3@citrix.com > >>> CC: konrad.wilk@oracle.com > >>> --- > >>> Removing Acks as I added the description of "Fixes" > >>> --- > >>> docs/process/tags.pandoc | 55 ++++++++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 55 insertions(+) > >>> create mode 100644 docs/process/tags.pandoc > >>> > >>> diff --git a/docs/process/tags.pandoc b/docs/process/tags.pandoc > >>> new file mode 100644 > >>> index 0000000000..06b06dda01 > >>> --- /dev/null > >>> +++ b/docs/process/tags.pandoc > >>> @@ -0,0 +1,55 @@ > >>> +Tags: No line splitting > >>> +----------------------- > >>> +Do not split a tag across multiple lines, tags are exempt from the > >>> +"wrap at 75 columns" rule in order to simplify parsing scripts. For > >>> +example: > >>> + > >>> + Fixes: 67d01cdb5 ("x86: infrastructure to allow converting certain indirect calls to direct ones") > >> > >> The SHA-1 ID is 9 characters but... > >> > >>> + > >>> + > >>> +Fixes Tag > >>> +--------- > >>> + > >>> +If your patch fixes a bug in a specific commit, e.g. you found an issue using > >>> +``git bisect``, please use the 'Fixes:' tag with the first 12 characters of > >>> +the SHA-1 ID, and the one line summary. > >> > >> ... you request 12 characters here. Can you make sure the two match please? > >> > >> However, I am not entirely sure why we should mandate 12 characters. With > >> the title, you should always be able to find back the commit if there is a > >> clash. > > > > This is copied from Linux's document. > > > > I normally use 8-9 characters, but I don't mind using 12 either. > > Are they still saying 9? I've been asked to switch to 12 several > weeks back ... I mean when I work on Xen I normally use 8 or 9. Not sure about Linux. Wei. > > Jan