Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD130C3A5A0 for ; Mon, 20 Apr 2020 14:44:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95D90206D5 for ; Mon, 20 Apr 2020 14:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgDTOoF (ORCPT ); Mon, 20 Apr 2020 10:44:05 -0400 Received: from bmailout2.hostsharing.net ([83.223.78.240]:56533 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgDTOoF (ORCPT ); Mon, 20 Apr 2020 10:44:05 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 79AFA2800B483; Mon, 20 Apr 2020 16:44:03 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 491E515BC99; Mon, 20 Apr 2020 16:44:03 +0200 (CEST) Date: Mon, 20 Apr 2020 16:44:03 +0200 From: Lukas Wunner To: Marek Vasut Cc: netdev@vger.kernel.org, "David S . Miller" , Petr Stetiar , YueHaibing Subject: Re: [PATCH V4 07/19] net: ks8851: Remove ks8851_rdreg32() Message-ID: <20200420144403.eoo47sq7pwp6yc7d@wunner.de> References: <20200414182029.183594-1-marex@denx.de> <20200414182029.183594-8-marex@denx.de> <20200420140700.6632hztejwcgjwsf@wunner.de> <99104102-7973-e80f-9006-9a448403562b@denx.de> <20200420142002.2l57umsi3rh5ka7e@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 20, 2020 at 04:24:05PM +0200, Marek Vasut wrote: > On 4/20/20 4:20 PM, Lukas Wunner wrote: > > On Mon, Apr 20, 2020 at 04:12:59PM +0200, Marek Vasut wrote: > >> On 4/20/20 4:07 PM, Lukas Wunner wrote: > >>> On Tue, Apr 14, 2020 at 08:20:17PM +0200, Marek Vasut wrote: > >>>> The ks8851_rdreg32() is used only in one place, to read two registers > >>>> using a single read. To make it easier to support 16-bit accesses via > >>>> parallel bus later on, replace this single read with two 16-bit reads > >>>> from each of the registers and drop the ks8851_rdreg32() altogether. > >>>> > >>>> If this has noticeable performance impact on the SPI variant of KS8851, > >>>> then we should consider using regmap to abstract the SPI and parallel > >>>> bus options and in case of SPI, permit regmap to merge register reads > >>>> of neighboring registers into single, longer, read. > >>> > >>> Bisection has shown this patch to be the biggest cause of the performance > >>> regression introduced by this series: Latency increases by about 9 usec. > >> > >> Just for completeness, did you perform this bisect on current linux-next > >> without any patches except this series OR your patched rpi downstream > >> vendor tree Linux 4.19 with preempt-rt patch applied ? > > > > The latter because latency without CONFIG_PREEMPT_RT_FULL=y is too imprecise > > to really see the difference and that's the configuration we care about. > > Why am I not able to see the same on the RPi3 then ? > How can I replicate this observation ? Compile this branch with CONFIG_PREEMPT_RT_FULL=y: https://github.com/l1k/linux/commits/revpi-4.19-marek-v4 Alternatively, download this file: http://wunner.de/ks8851-marekv4.tar Install the "raspberrypi-kernel" deb-package included in the tarball on a stock Raspbian image and copy one of the included ks8851.ko to: /lib/modules/4.19.95-rt38-v7+/kernel/drivers/net/ethernet/micrel Thanks, Lukas