From: Andrew Morton Date: Mon, 20 Apr 2020 22:42:10 -0700 Subject: [Cluster-devel] [PATCH v11 19/25] erofs: Convert compressed files from readpages to readahead In-Reply-To: <20200414150233.24495-20-willy@infradead.org> References: <20200414150233.24495-1-willy@infradead.org> <20200414150233.24495-20-willy@infradead.org> Message-ID: <20200420224210.dff005bc62957a4d81d58226@linux-foundation.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, 14 Apr 2020 08:02:27 -0700 Matthew Wilcox wrote: > > Use the new readahead operation in erofs. > Well this is exciting. fs/erofs/data.c: In function erofs_raw_access_readahead: fs/erofs/data.c:149:18: warning: last_block may be used uninitialized in this function [-Wmaybe-uninitialized] *last_block + 1 != current_block) { It seems to be a preexisting bug, which your patch prompted gcc-7.2.0 to notice. erofs_read_raw_page() goes in and uses *last_block, but neither of its callers has initialized it. Could the erofs maintainers please take a look?