Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E3CC54FC9 for ; Tue, 21 Apr 2020 10:44:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E08D205C9 for ; Tue, 21 Apr 2020 10:44:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="U2oFoFfG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E08D205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQqNV-0000Eh-HG; Tue, 21 Apr 2020 10:43:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQqNU-0000Ec-IJ for xen-devel@lists.xenproject.org; Tue, 21 Apr 2020 10:43:44 +0000 X-Inumbo-ID: f80f3406-83bc-11ea-9123-12813bfff9fa Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f80f3406-83bc-11ea-9123-12813bfff9fa; Tue, 21 Apr 2020 10:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1587465822; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hInLTlMqqYT4W2C4qBKheXcnwqmrBCfPj09AVeWtvO8=; b=U2oFoFfGRgA+vzig4QnIvDun+WiPdTtuhQWrF6x6udHq7gnx/0gywI16 nabtt/XjZiaJ1+1NLqVV4u8Q0inOb2kwCvRmgM21eqheff5f5Ki0oPmgN +/40RgQhOyYyCwUJCjCyxr5URIcrYKX65mweT9P/EKP07cbwHQjxgrHJk 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: zL0XnSXuyOUbPlOkfG+xKKetCQ/USDct8YzlERuXbteFWJ0MiNVEJ3/i+ynJLq7ggLjrPKB4g6 sW/ryoxJBQCmoH8Qhw6CQKjZK4cTj99whYe2aiD/iehVaJLw19f/Giu5Lza2LH/CzWlC2saZMh EByDe9yxRL4IFJGqEmwx4NXtjkmge1ws5itl8rMzi1rNT+gFvNhdL8NCilDZxcs8gjySkwn2Lo 07p0xj69uDneJpw5S+FQtpxoLS7PxTcxr3+2MWUgu0kakoIj8xW5eSNP40q078hFDszqqREW6K vV0= X-SBRS: 2.7 X-MesageID: 16669647 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.72,410,1580792400"; d="scan'208";a="16669647" Date: Tue, 21 Apr 2020 12:43:35 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH v10 1/3] x86/tlb: introduce a flush HVM ASIDs flag Message-ID: <20200421104335.GU28601@Air-de-Roger> References: <20200416135909.16155-1-roger.pau@citrix.com> <20200416135909.16155-2-roger.pau@citrix.com> <80288e76-aff6-61d5-71aa-ae7c8e9d9a65@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <80288e76-aff6-61d5-71aa-ae7c8e9d9a65@suse.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Tim Deegan , George Dunlap , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Apr 21, 2020 at 12:21:12PM +0200, Jan Beulich wrote: > On 16.04.2020 15:59, Roger Pau Monne wrote: > > Introduce a specific flag to request a HVM guest linear TLB flush, > > which is an ASID/VPID tickle that forces a guest linear to guest > > physical TLB flush for all HVM guests. > > > > This was previously unconditionally done in each pre_flush call, but > > that's not required: HVM guests not using shadow don't require linear > > TLB flushes as Xen doesn't modify the guest page tables in that case > > (ie: when using HAP). > > I'm afraid I'm being confused by this: Even in shadow mode Xen > doesn't modify guest page tables, does it? I'm also confused now. It's my understand that when running in shadow mode guest page tables are not actually used, and the guest uses Xen's crafted shadow tables instead, which are based on the original guest page tables suitably adjusted by Xen in order to do the p2m translation in the HVM case, or the needed PTE adjustments in the PV case. So guest page tables are not modified, but are also not used as they are never loaded into cr3. > > @@ -254,3 +257,14 @@ unsigned int flush_area_local(const void *va, unsigned int flags) > > > > return flags; > > } > > + > > +void guest_flush_tlb_mask(const struct domain *d, const cpumask_t *mask) > > +{ > > + unsigned int flags = (is_pv_domain(d) || paging_mode_shadow(d) ? FLUSH_TLB > > + : 0) | > > + (is_hvm_domain(d) && cpu_has_svm ? FLUSH_HVM_ASID_CORE > > + : 0); > > Why the is_pv_domain() part of the condition? Afaict for PV > domains you can get here only if they have shadow mode enabled. Right now yes, the only way to get here for PV domains is when using shadow, but if this helper gets used in other non-shadow PV paths then Xen's needs to do a TLB flush. > > --- a/xen/arch/x86/mm/shadow/private.h > > +++ b/xen/arch/x86/mm/shadow/private.h > > @@ -818,6 +818,12 @@ static inline int sh_check_page_has_no_refs(struct page_info *page) > > bool shadow_flush_tlb(bool (*flush_vcpu)(void *ctxt, struct vcpu *v), > > void *ctxt); > > > > +static inline void sh_flush_local(const struct domain *d) > > +{ > > + flush_local(FLUSH_TLB | > > + (is_hvm_domain(d) && cpu_has_svm ? FLUSH_HVM_ASID_CORE : 0)); > > +} > > I think the right side of | wants folding with its counterpart in > guest_flush_tlb_mask(). Doing so would avoid guest_flush_tlb_mask() > getting updated but this one forgotten. Perhaps split out > guest_flush_tlb_flags() from guest_flush_tlb_mask()? Can do. > I also think this function should move into multi.c as long as it's > needed only there. Ack. Thanks, Roger.