Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5F1C54FCC for ; Tue, 21 Apr 2020 14:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E3ED206A1 for ; Tue, 21 Apr 2020 14:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="CPDR2qKj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728963AbgDUOvD (ORCPT ); Tue, 21 Apr 2020 10:51:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54212 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbgDUOvD (ORCPT ); Tue, 21 Apr 2020 10:51:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8Qynf6hcLm2W/HhSDd8tPztQA+MysekaejQSi+2hhk0=; b=CPDR2qKjZV2X/H2PE8UZcmkZul 8ImSTp8v4SUbHT7q+fufkRKFY23Kywx7R6etZoDudVi9sy5Oa+barX6Ia8KAEzlmndHj5tHM/excM dinEZX0XyzbBgpwQ6xO8XQsm7uL/1BeKZwCswHFESEx1/IaKSTtP98KXHsPCrbwoRTdM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jQuEl-0042c2-7e; Tue, 21 Apr 2020 16:50:59 +0200 Date: Tue, 21 Apr 2020 16:50:59 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Florian Fainelli , Vivien Didelot , "David S. Miller" , Oleksij Rempel , netdev Subject: Re: [PATCH net 1/2] net: dsa: be compatible with DSA masters with max_mtu of 1500 or less Message-ID: <20200421145059.GC933345@lunn.ch> References: <20200421123110.13733-1-olteanv@gmail.com> <20200421123110.13733-2-olteanv@gmail.com> <20200421133321.GD937199@lunn.ch> <20200421140653.GA933345@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > We have always assumed the slave can send normal sized frames, > > independent of what the master supports. This is just a follow on from > > the fact we ignore errors setting the MTU on the master for the DSA > > overhead for normal size frames. So don't set the MTU to 1496, leave > > it at 1500. For all working boards out in the wild, 1500 will work. > > > > Andrew > > Does iperf3 TCP work on your Vybrid board with the master MTU equal to > the slave MTU equal to 1500 (without IP fragmentation, that is)? If it > does, ok, this patch can maybe be dropped. Yes it does. > qca7000 doesn't support packets larger than 1500 MTU either, neither > does broadcom b44, and neither do probably more adapters which I > didn't find now. And unfortunately, there are probably a similar number of devices which do work, and don't have correct MTU settings. So long as the IP stack does MTU correctly, it does not matter what the network device does with frames bigger than the MTU. And so network devices whos MTU handling is wrong never causes issues, and so never get detected and fixed. We have to live in a world where trying to be correct is going to cause regressions because of poor decisions in the past. But we can do jumbo correctly, since it is new, it cannot regress. And doing jumbo correct will help find some of these network drivers which do MTU settings wrong. Andrew