Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A50EC54FCC for ; Tue, 21 Apr 2020 18:11:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA11920663 for ; Tue, 21 Apr 2020 18:11:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RrH76cWj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA11920663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5edcyZyAQvUtBWLwvieaFYHO7sD5OYMwGWb62kFVBGs=; b=RrH76cWjpZX/O5 IGk1OzSt9B0bWxZhoOsGsdK7Qc47+zJWb323DGq8eO8/fEIJI9XGAPrVxDi3+TIEnOQsH1opvCeR9 7IBil0LkfrdIwanCzvN2BSqllr6jRnPdSBEjH7VmC/QJJJFAqlWjkhHAPluETcPbYxe0LHwPIsVfX otAP7NaWCEhQM8Nsj3vK+mRe5sUsEJnjCnlVnaXocN5WfDzUbrgtTmerLLHTMMkWnkWJpUP4qlooc UFDR9E2j/f/F5L8U6YOz3C0wo6IQKXRtbAUcLCPZeTXbst5mCQ3VGFFLS7K2UgCBKKUCFdyDoxpSv bEFm8gXXy93HADAXkkwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQxMi-0006xZ-7U; Tue, 21 Apr 2020 18:11:24 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQxMh-0006xH-1D; Tue, 21 Apr 2020 18:11:23 +0000 Date: Tue, 21 Apr 2020 11:11:23 -0700 From: Christoph Hellwig To: James Smart Subject: Re: [RFC 5/6] nvme: Add pi_flags to nvme_request for transport pi support Message-ID: <20200421181123.GE31265@infradead.org> References: <20200224184859.20995-1-jsmart2021@gmail.com> <20200224184859.20995-6-jsmart2021@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200224184859.20995-6-jsmart2021@gmail.com> X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Feb 24, 2020 at 10:48:58AM -0800, James Smart wrote: > Create a new field called pi_flags in the nvme request. This field > uses the enum nvme_transport_flags definition. However, they are set in > a different manner: > NVME_F_FABRICS and NVME_F_PCI_P2PDMA will not be set. > NVME_F_METADATA_SUPPORTED will not be set. The transport must look > for blk_request_rq() to determine that there is metadata. > Note: There may or may not be PI when set. > If there is PI and metadata, only the NVME_F_PI_TYPE_xxx flag for the > ns's pi type will be set. > If there is PI and no metadata, the NVME_F_PI_TXINSERT_RXSTRIP flag > may be set. I don't think reusing the same values for such a different field is a good idea. I also really have no idea how you are going to use these just based on this patch. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme