Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6050EC54FCB for ; Wed, 22 Apr 2020 16:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B5C420774 for ; Wed, 22 Apr 2020 16:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgDVQLM (ORCPT ); Wed, 22 Apr 2020 12:11:12 -0400 Received: from elvis.franken.de ([193.175.24.41]:50617 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbgDVQLL (ORCPT ); Wed, 22 Apr 2020 12:11:11 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jRHxm-0002nO-00; Wed, 22 Apr 2020 18:11:02 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 10950C02B8; Wed, 22 Apr 2020 18:10:45 +0200 (CEST) Date: Wed, 22 Apr 2020 18:10:45 +0200 From: Thomas Bogendoerfer To: Huacai Chen Cc: linux-mips@vger.kernel.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , Jiaxun Yang , Pei Huang , Shuangshuang Zhang Subject: Re: [PATCH V2 2/3] MIPS: Move unaligned load/store helpers to inst.h Message-ID: <20200422161044.GA22753@alpha.franken.de> References: <1587548422-10707-1-git-send-email-chenhc@lemote.com> <1587548422-10707-2-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587548422-10707-2-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Apr 22, 2020 at 05:40:21PM +0800, Huacai Chen wrote: > Move unaligned load/store helpers from unaligned.c to inst.h, then > other parts of the kernel can use these helpers. > > Signed-off-by: Pei Huang > Signed-off-by: Shuangshuang Zhang > Signed-off-by: Huacai Chen > Reviewed-by: Jiaxun Yang > --- > arch/mips/include/asm/inst.h | 773 ++++++++++++++++++++++++++++++++++++++++++ > arch/mips/kernel/unaligned.c | 775 ------------------------------------------- this patch still has checkpatch errors/warnings and more serious it breaks at least IP30 builds. Patch 3 also contains checkpatch errors. Please fix them before submitting again. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]