Content-Type: multipart/mixed; boundary="===============2555767611003146992==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 2/3] net: mscc: ocelot: refine the ocelot_ace_is_problematic_mac_etype function Date: Thu, 23 Apr 2020 10:23:08 +0800 Message-ID: <202004231032.OE8Eii2x%lkp@intel.com> In-Reply-To: <20200420162743.15847-3-olteanv@gmail.com> List-Id: --===============2555767611003146992== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20200421] [cannot apply to net/master linus/master sparc-next/master v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Ocelot-MAC= _ETYPE-tc-flower-key-improvements/20200422-113906 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git = b6246f4d8d0778fd045b84dbd7fc5aadd8f3136e reproduce: # apt-get install sparse # sparse version: v0.6.1-191-gc51a0382-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/net/ethernet/mscc/ocelot_ace.c:747:17: sparse: sparse: cast to r= estricted __be16 >> drivers/net/ethernet/mscc/ocelot_ace.c:747:17: sparse: sparse: cast to r= estricted __be16 >> drivers/net/ethernet/mscc/ocelot_ace.c:747:17: sparse: sparse: cast to r= estricted __be16 >> drivers/net/ethernet/mscc/ocelot_ace.c:747:17: sparse: sparse: cast to r= estricted __be16 drivers/net/ethernet/mscc/ocelot_ace.c:748:16: sparse: sparse: cast to r= estricted __be16 drivers/net/ethernet/mscc/ocelot_ace.c:748:16: sparse: sparse: cast to r= estricted __be16 drivers/net/ethernet/mscc/ocelot_ace.c:748:16: sparse: sparse: cast to r= estricted __be16 drivers/net/ethernet/mscc/ocelot_ace.c:748:16: sparse: sparse: cast to r= estricted __be16 vim +747 drivers/net/ethernet/mscc/ocelot_ace.c 739 = 740 static bool ocelot_ace_is_problematic_mac_etype(struct ocelot_ace_ru= le *ace) 741 { 742 u16 proto, mask; 743 = 744 if (ace->type !=3D OCELOT_ACE_TYPE_ETYPE) 745 return false; 746 = > 747 proto =3D ntohs(*(u16 *)ace->frame.etype.etype.value); 748 mask =3D ntohs(*(u16 *)ace->frame.etype.etype.mask); 749 = 750 /* ETH_P_ALL match, so all protocols below are included */ 751 if (mask =3D=3D 0) 752 return true; 753 if (proto =3D=3D ETH_P_ARP) 754 return true; 755 if (proto =3D=3D ETH_P_IP) 756 return true; 757 if (proto =3D=3D ETH_P_IPV6) 758 return true; 759 = 760 return false; 761 } 762 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2555767611003146992==--