Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C9EC54FCB for ; Thu, 23 Apr 2020 13:11:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B69BF2076C for ; Thu, 23 Apr 2020 13:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="LgxagEnZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69BF2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRbdi-0000AL-CM; Thu, 23 Apr 2020 13:11:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRbdg-0000A9-K1 for xen-devel@lists.xenproject.org; Thu, 23 Apr 2020 13:11:36 +0000 X-Inumbo-ID: f4b914ae-8563-11ea-936a-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f4b914ae-8563-11ea-936a-12813bfff9fa; Thu, 23 Apr 2020 13:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=Ktn+b1AR1qHekEIzVhz3tD/UWrG7ZsYuOfaVlGjXTtE=; b=LgxagEnZ2RiedO5iOUK3fjy+i9 eyGIfIEmFso1rlaQ+e/VhljOj8LJiKHu4JWmy9zlB9IPMrVP0sXlI1U2Nv73PD5l/WoBCKTyworqR otP2LX7UIWaPlu508FWH941zfZpUPzVKX8wZ7gru/A4q/sdIhQx4sNrMmE9XA+HCyg00=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRbdb-0003qG-Uj; Thu, 23 Apr 2020 13:11:31 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRbdb-0002ba-Kj; Thu, 23 Apr 2020 13:11:31 +0000 Date: Thu, 23 Apr 2020 14:11:29 +0100 From: Wei Liu To: George Dunlap Subject: Re: [PATCH 1/2] tools: build golang tools if go compiler is present Message-ID: <20200423131129.chfzcnkjvilnzedb@debian> References: <20200423102538.vxuo7s2lamkxhoo7@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , xen-devel , Ian Jackson , Nick Rosbrook , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Apr 23, 2020 at 01:09:43PM +0100, George Dunlap wrote: > On Thu, Apr 23, 2020 at 11:25 AM Wei Liu wrote: > > > On Wed, Apr 22, 2020 at 08:25:25PM -0400, Nick Rosbrook wrote: > > > By default, if the go compiler is found by the configure script, build > > > the golang tools. If the compiler is not found, and > > > --enable-golang_tools was not explicitly set, do not build to the golang > > > > --enable-golang-tools here. > > > > > tools. > > > > > > The new corresponding make variable is CONFIG_GOLANG_TOOLS. Remove > > > CONFIG_GOLANG from tools/Rules.mk since the new variable is set by > > > configure. > > > > > > Signed-off-by: Nick Rosbrook > > > > Acked-by: Wei Liu > > > > Note to self: fix commit message and maybe rerun autogen.sh. > > > > It doesn't look like that's a typo -- if you want it to be `-` instead of > `_`, the patch needs to be changed (at least as far as I can tell w/ my > admittedly limited automake-foo). My bad. The code indeed says --enable-golang_tools. Wei. > > -George