Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A85C55186 for ; Fri, 24 Apr 2020 07:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 303812075A for ; Fri, 24 Apr 2020 07:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbgDXHOh (ORCPT ); Fri, 24 Apr 2020 03:14:37 -0400 Received: from verein.lst.de ([213.95.11.211]:33553 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbgDXHOh (ORCPT ); Fri, 24 Apr 2020 03:14:37 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 723C768CEE; Fri, 24 Apr 2020 09:14:33 +0200 (CEST) Date: Fri, 24 Apr 2020 09:14:33 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, kbusch@kernel.org, sagi@grimberg.me, martin.petersen@oracle.com, jsmart2021@gmail.com, linux-rdma@vger.kernel.org, idanb@mellanox.com, axboe@kernel.dk, vladimirk@mellanox.com, oren@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH 14/17] nvmet: Add metadata/T10-PI support Message-ID: <20200424071433.GE24059@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-16-maxg@mellanox.com> <20200421153045.GE10837@lst.de> <0c6caf5b-693b-74af-670e-7df9c7f9c829@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c6caf5b-693b-74af-670e-7df9c7f9c829@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Apr 23, 2020 at 03:39:38PM +0300, Max Gurtovoy wrote: >>> + if (ctrl->subsys->pi_support && ctrl->port->pi_enable) { >>> + if (ctrl->port->pi_capable) { >>> + ctrl->pi_support = true; >>> + pr_info("controller %d T10-PI enabled\n", ctrl->cntlid); >>> + } else { >>> + ctrl->pi_support = false; >>> + pr_warn("T10-PI is not supported on controller %d\n", >>> + ctrl->cntlid); >>> + } >> I think the printks are a little verbose. Also why can we set >> ctrl->port->pi_enable if ctrl->port->pi_capable is false? Shoudn't >> we reject that earlier? In that case this could simply become: >> >> ctrl->pi_support = ctrl->subsys->pi_support && ctrl->port->pi_enable; > > for that we'll need to check pi_capable during add_port process and disable > pi_enable bit if user set it. Which seems pretty sensible. In fact I think the configfs write for pi enable should fail if we don't have the capability. > User should set it before enable the port (this will always succeed). > > I'll make this change as well. > > re the verbosity, sometimes I get many requests from users to get > indication for some features. > > We can remove this as well if needed. I'd rather keep debug prints silent. You could add a verbose mode in nvmetcli that prints all the settings applied if that helps these users.