Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C819C2BA1A for ; Fri, 24 Apr 2020 10:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1341B20767 for ; Fri, 24 Apr 2020 10:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbgDXKI4 (ORCPT ); Fri, 24 Apr 2020 06:08:56 -0400 Received: from 3.mo1.mail-out.ovh.net ([46.105.60.232]:52925 "EHLO 3.mo1.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbgDXKI4 (ORCPT ); Fri, 24 Apr 2020 06:08:56 -0400 X-Greylist: delayed 1802 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Apr 2020 06:08:55 EDT Received: from player797.ha.ovh.net (unknown [10.108.42.167]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 70E291BCE28 for ; Fri, 24 Apr 2020 11:29:46 +0200 (CEST) Received: from etezian.org (213-243-141-64.bb.dnainternet.fi [213.243.141.64]) (Authenticated sender: andi@etezian.org) by player797.ha.ovh.net (Postfix) with ESMTPSA id 37B20DAAF37C; Fri, 24 Apr 2020 09:29:39 +0000 (UTC) Date: Fri, 24 Apr 2020 12:29:37 +0300 From: Andi Shyti To: Stephan Gerhold Cc: Dmitry Torokhov , Andi Shyti , linux-input@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] Input: mms114 - add extra compatible for mms345l Message-ID: <20200424092937.GB460760@jack.zhora.eu> References: <20200423102431.2715-1-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423102431.2715-1-stephan@gerhold.net> X-Ovh-Tracer-Id: 12793037691999273709 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrhedugddugecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucfkpheptddrtddrtddrtddpvddufedrvdegfedrudeguddrieegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeeljedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdprhgtphhtthhopeguvghvihgtvghtrhgvvgesvhhgvghrrdhkvghrnhgvlhdrohhrgh Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi guys, > }, { > .compatible = "melfas,mms152", > .data = (void *)TYPE_MMS152, > + }, { > + .compatible = "melfas,mms345l", > + .data = (void *)TYPE_MMS345L, > }, it's been some times I haven't been doing this, but is the order of the patches correct? shouldn't the binding be updated first? Andi