From: Christoph Hellwig Date: Sun, 26 Apr 2020 07:17:15 +0000 Subject: Re: [PATCH 2/5] arch/kmap: Remove redundant arch specific kmaps Message-Id: <20200426071715.GA22024@infradead.org> List-Id: References: <20200426055406.134198-1-ira.weiny@intel.com> <20200426055406.134198-3-ira.weiny@intel.com> In-Reply-To: <20200426055406.134198-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ira.weiny@intel.com Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Sat, Apr 25, 2020 at 10:54:03PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap code for all the architectures is almost 100% identical. > > Lift the common code to the core. Use ARCH_HAS_KMAP to indicate if an > arch needs a special kmap. Can you add a kmap_flush_tlb hook that csky and mips define, and the just entirely consolidate the code instead?