From: Ira Weiny Date: Mon, 27 Apr 2020 01:16:30 +0000 Subject: Re: [PATCH 4/5] arch/kmap_atomic: Consolidate duplicate code Message-Id: <20200427011630.GC135929@iweiny-DESK2.sc.intel.com> List-Id: References: <20200426055406.134198-1-ira.weiny@intel.com> <20200426055406.134198-5-ira.weiny@intel.com> <20200426072642.GB22024@infradead.org> In-Reply-To: <20200426072642.GB22024@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Sun, Apr 26, 2020 at 12:26:42AM -0700, Christoph Hellwig wrote: > > diff --git a/arch/arc/mm/highmem.c b/arch/arc/mm/highmem.c > > index 4db13a6b9f3b..1cae4b911a33 100644 > > --- a/arch/arc/mm/highmem.c > > +++ b/arch/arc/mm/highmem.c > > @@ -53,11 +53,10 @@ void *kmap_atomic(struct page *page) > > { > > int idx, cpu_idx; > > unsigned long vaddr; > > + void *addr = kmap_atomic_fast(page); > > > > - preempt_disable(); > > - pagefault_disable(); > > - if (!PageHighMem(page)) > > - return page_address(page); > > + if (addr) > > + return addr; > > Wouldn't it make sense to just move kmap_atomic itelf to common code, > and call out to a kmap_atomic_high for the highmem case, following the > scheme in kmap? > Sure I do like that symmetry between the calls. > > Same for the unmap side. FWIW that would simply be renaming __kunmap_atomic() to kunmap_atomic_high() > > That might require to support > kmap_atomic_prot everywhere first, which sounds like a really good > idea anyway, and would avoid the need for strange workaround in drm. Having a kmap_atomic_prot() seems like a good idea. But I'm not exactly sure why CONFIG_x86 is being called out specifically in the DRM code? Ira