Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B552FC7C822 for ; Mon, 27 Apr 2020 08:20:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C7DA20661 for ; Mon, 27 Apr 2020 08:20:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="els4jAlp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C7DA20661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7067B6E0FC; Mon, 27 Apr 2020 08:20:09 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CC0C6E0A1 for ; Mon, 27 Apr 2020 08:19:24 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id u15so16613688ljd.3 for ; Mon, 27 Apr 2020 01:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ko7ECkbpkrfY4zRKx21hcLUoTE3ne5ZVCyMO+vbIqD8=; b=els4jAlplL1YN1+7Ymn7N99XGmW60iCbzDoo3MReeet8oHMQl/ORWvvv+8Yj2oab91 nE87K83GiVlBjYOMA0mrp2Y7k1mdQwDxGtsqe9HUiBLpuxGXujszOxxbLgZo6fanTIAI sa+tcc8v6m0/MMgl7z6LNVSNZu5H2ezw7GZ29Sx7BzqqTkq9EKfWzv6x0MAESUX3GWML Ft+RXkXl96ON7a4GjZOfj6f2v7b3yPogJSToV61VyyC1oFiJYbwRKLlHmWaZamEU2YdC knbl0sMg9vCd1BGp6cOW5pbrDC/7fBL2lIUrTI9b7clfutlt/uNmhjZimU1Llw7AN4Dz 9hLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ko7ECkbpkrfY4zRKx21hcLUoTE3ne5ZVCyMO+vbIqD8=; b=nV0O5FdASiPpxcZUT5iAI2NLy7op71C+4odOxX69U8BZRiwTvTOLRAX2lSFoZ3CzBp +6HctCtd4T0s0k17q+MSlV/0xOwHMotLjLegrtcFDL4cvMnBNdRU2kGFt794Y5XfSW4Q PXyiEcmO7MuhDHDV+drUT7we4hwsNBPbb27SE01YT0V326mMspoKmWPLgKBIBqAh5I8X 1U8O3tmVaEolAGSQdUZ4GgtdmxH34ayjhwdRula1SRnVX82ddf7ZQl436ewIN4sxbwIa Vl+c0t89I9RIJYHv1sMuaa9wmm2zYf3GYibgooGI9ZXojYK/fQwZZ0UWXDoZuta2F9G1 h/NA== X-Gm-Message-State: AGi0Pua+dMjrX/uHtwb1axfZPS1aGijx2NflKq4Mp6+hXWLOWOuEApvi n1M+11eDBYFgwX6paSQPnaN14wta X-Google-Smtp-Source: APiQypLoJvNFvtfW4LTmWbf2iV70ATmDA81pckGQq7lyU4lWS/z80rZa36RBaNum6PWTb2LesSMC2Q== X-Received: by 2002:a2e:9207:: with SMTP id k7mr13520918ljg.124.1587975562137; Mon, 27 Apr 2020 01:19:22 -0700 (PDT) Received: from saturn.lan (18.158-248-194.customer.lyse.net. [158.248.194.18]) by smtp.gmail.com with ESMTPSA id c20sm9846301ljk.59.2020.04.27.01.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 01:19:21 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Laurent Pinchart , Neil Armstrong Subject: [PATCH v2 17/21] drm/bridge: megachips: make connector creation optional Date: Mon, 27 Apr 2020 10:18:46 +0200 Message-Id: <20200427081850.17512-18-sam@ravnborg.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427081850.17512-1-sam@ravnborg.org> References: <20200427081850.17512-1-sam@ravnborg.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Martyn Welch , Jonas Karlman , Peter Senna Tschudin , Andrzej Hajda , Thierry Reding , Sam Ravnborg , Martin Donnelly Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Make the connector creation optional to enable usage of the megachips-stdpxxxx-ge-b850v3-fw bridge with the DRM bridge connector helper. Signed-off-by: Sam Ravnborg Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Welch Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c index 5f06e18f0a61..991417ab35b6 100644 --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c @@ -251,16 +251,6 @@ static int ge_b850v3_lvds_attach(struct drm_bridge *bridge, { struct i2c_client *stdp4028_i2c = ge_b850v3_lvds_ptr->stdp4028_i2c; - int ret; - - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { - DRM_ERROR("Fix bridge driver to make connector optional!"); - return -EINVAL; - } - - ret = ge_b850v3_lvds_create_connector(bridge); - if (ret) - return ret; /* Configures the bridge to re-enable interrupts after each ack. */ i2c_smbus_write_word_data(stdp4028_i2c, @@ -272,7 +262,10 @@ static int ge_b850v3_lvds_attach(struct drm_bridge *bridge, STDP4028_DPTX_IRQ_EN_REG, STDP4028_DPTX_IRQ_CONFIG); - return 0; + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) + return 0; + + return ge_b850v3_lvds_create_connector(bridge); } static const struct drm_bridge_funcs ge_b850v3_lvds_funcs = { -- 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel