Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9443C83000 for ; Tue, 28 Apr 2020 14:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF29206E2 for ; Tue, 28 Apr 2020 14:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgD1OY7 (ORCPT ); Tue, 28 Apr 2020 10:24:59 -0400 Received: from verein.lst.de ([213.95.11.211]:56569 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727843AbgD1OY6 (ORCPT ); Tue, 28 Apr 2020 10:24:58 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 1963168CEC; Tue, 28 Apr 2020 16:24:57 +0200 (CEST) Date: Tue, 28 Apr 2020 16:24:56 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , "axboe@kernel.dk" , "hannes@cmpxchg.org" , "linux-block@vger.kernel.org" Subject: Re: [PATCH 3/4] block: replace BIO_QUEUE_ENTERED with BIO_CGROUP_ACCT Message-ID: <20200428142456.GB5646@lst.de> References: <20200428112756.1892137-1-hch@lst.de> <20200428112756.1892137-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 28, 2020 at 02:23:52PM +0000, Johannes Thumshirn wrote: > This is completely unrelated to the patch, but why is > blkcg_bio_issue_check() static inline? It's only called in > generic_make_request_checks(). The whole blk-cgroup group is just crazy :( This isn't even the worst part of it.