Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93A2C83000 for ; Tue, 28 Apr 2020 14:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99BED206C0 for ; Tue, 28 Apr 2020 14:33:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="NtgeuWKq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99BED206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2C166E7EF; Tue, 28 Apr 2020 14:33:40 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 699DA6E7EF for ; Tue, 28 Apr 2020 14:33:39 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id k13so24944137wrw.7 for ; Tue, 28 Apr 2020 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AjieViA3rnxqYDhF0kJNrJxehbwh0Gzk+1e36Gl2Pak=; b=NtgeuWKqE8X8T1xWg2iWqWjvywaHyu3n1L4Ws6gzNcDukV8UildbmlpdQ2V4jvrff9 iqYGuPQqN1zUhYNJ0ukcqLruOyfKNLdU0ZM0A0aC+z9CHDFjmX0Dff0FE1cA49zICt9w cr09OpX2CVF7njP6JJ5vYKHaAwf0G8xa/TrsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AjieViA3rnxqYDhF0kJNrJxehbwh0Gzk+1e36Gl2Pak=; b=eAx1cX9zFrviK1DeX5R4ckfj15qu5AKLnvGp+Wai646VlH3AkPw+eH3HTqcfv2DjtG o4z7KAV/JF0gf8DHZ2hOQVtSERTtLK8HKIm3QkiVf98yA1ld/U6/4X1k9MHOnDb05qHy yc2uaBMCrtsrqZKF6ettrVNOM04NfNqF/qHb4hHu+Oh3U0TNd9wTl9lKj8CSikj5i/5p gkWL8PYl8ltYkPaLStoQ/F7fKaI1Zhvk3nt7qYrpICe+GrL0BcjAV2bjVUMRSBY+HscE nxDDypFNR1wyGCyFHShm4SjyDoHMI41Kfzxi8ckw7LNJQVpSXUFz1qL5zzxjYEz9+yZP l73A== X-Gm-Message-State: AGi0PubdrcmZSPsNH3JD6tLAiZaBbAWAxHdOQmL+SV6C0YATJxMtbba5 RczaQdDqWKo+RvVHDfsAD3TwH4vIgqU= X-Google-Smtp-Source: APiQypI50Y/dMBlhnWNbEi1tbW+JJ68XwuNtliiwfdwdiAw1WYUWnB3DameCvp4r6I0/G7PXZZx2VQ== X-Received: by 2002:adf:ea44:: with SMTP id j4mr36157713wrn.38.1588084418072; Tue, 28 Apr 2020 07:33:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l19sm3580012wmj.14.2020.04.28.07.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 07:33:37 -0700 (PDT) Date: Tue, 28 Apr 2020 16:33:35 +0200 From: Daniel Vetter To: Ben Davis Subject: Re: [PATCH] drm: drm_fourcc: Add uncompressed AFBC modifier Message-ID: <20200428143335.GO3456981@phenom.ffwll.local> References: <20200422111758.1787-1-ben.davis@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200422111758.1787-1-ben.davis@arm.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liviu.dudau@arm.com, matteo.franchin@arm.com, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, nd@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 22, 2020 at 12:17:58PM +0100, Ben Davis wrote: > AFBC has a mode that allows use of AFBC with an uncompressed buffer, > we add a new modifier to support this mode. > > Signed-off-by: Ben Davis > --- > include/uapi/drm/drm_fourcc.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 8bc0b31597d8..97c47baef7fc 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -780,6 +780,12 @@ extern "C" { > */ > #define AFBC_FORMAT_MOD_BCH (1ULL << 11) > > +/* AFBC uncompressed storage mode > + * > + * Indicates that the buffer is using uncompressed AFBC mode. Since this sounds a bit baffling, might be good to spend a few more words on what exactly this means. If it's just a fancy way of saying linear/untiled, then this shouldn't be a modifier. If it's some kind of specific tiling layout, then I think that should be specified (we've been a bit more lax with the compressor magic soup, but tiled formats are generally fully specced). -Daniel > + */ > +#define AFBC_FORMAT_MOD_USM (1ULL << 12) > + > /* > * Arm 16x16 Block U-Interleaved modifier > * > -- > 2.24.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel