Return-Path: DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 5939027FB06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1588101159; bh=BJT89DPVc3AH4o8EbhkkKWSRcUUTh3DrJkIACGD5vKU=; h=From:To:Date:Message-Id; b=DAGZn1r8LT3zsNP8nY80Nbu0ESA/web9lzaHCwH2Yr07dGFqf9dJasuULaojzuVX/ 7aSqlZ4E5dD+oVyD/sHbK5T/vH99n9USQmz+LrIMbkFoOvE964XKW5Uk7E0b9Dac4X Xe8vn5KBraeCbL+FXS4YzZaufpW1XPssf0wjGaigUZaT3GrYJbb3X65Kk4HPqds6QM Yxe593/pwXWDUFHyYJ1J0k7l4omx6eERsZJUveRZJM+PaxKUOfzGuywEwcfK3V8X7F F+6JhJJ2lqMuVxpWvP08/frGYl4K2Obw8Zb3MJYfoYf0sXM0NR4pmCPm6p/DODsll8 +9iEzzEqOMMzA== From: Mathieu Desnoyers Date: Tue, 28 Apr 2020 15:12:26 -0400 Message-Id: <20200428191227.16560-3-mathieu.desnoyers@efficios.com> In-Reply-To: <20200428191227.16560-1-mathieu.desnoyers@efficios.com> References: <20200428191227.16560-1-mathieu.desnoyers@efficios.com> Subject: [diamon-discuss] [RFC PATCH CTF 3/4] Clarify that timestamp begin/end need to be complete clock values List-Id: DiaMon diagnostic and monitoring workgroup general discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: diamon-discuss@lists.linuxfoundation.org Cc: Jeremie Galarneau , lttng-dev@lists.lttng.org, Genevieve Bastien Signed-off-by: Mathieu Desnoyers --- common-trace-format-specification.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/common-trace-format-specification.md b/common-trace-format-specification.md index 55d0601..5732e92 100644 --- a/common-trace-format-specification.md +++ b/common-trace-format-specification.md @@ -837,11 +837,12 @@ TSDL metadata): assigned to events contained within the packet. The timestamp at the beginning of an event packet is guaranteed to be below or equal the timestamp at the end of that event packet. The timestamp at the - beginning of an event packet is guaranteed to be above or equal the - timestamps at the beginning of any prior packet within the same - stream. The timestamp at the end of an event packet is guaranteed to - be below or equal the timestamps at the end of any following packet - within the same stream. See [Clocks](#spec8) for more detail. + beginning of an event packet is guaranteed to be grater than or + equal to timestamps at the beginning of any prior packet within the + same stream. The timestamp at the end of an event packet is + guaranteed to be less than or equal to the timestamps at the end of + any following packet within the same stream. See [Clocks](#spec8) + for more detail. * **Events discarded count**. Snapshot of a per-stream free-running counter, counting the number of events discarded that were supposed to be written in the stream after the last event in @@ -1580,7 +1581,8 @@ stream { }; ~~~ -For a N-bit integer type referring to a clock, if the integer overflows +Within the stream event context, event context, and event payload, +fields of N-bit integer type referring to a clock, if the integer overflows compared to the N low order bits of the clock prior value found in the same stream, then it is assumed that one, and only one, overflow occurred. It is therefore important that events encoding time on a small @@ -1589,8 +1591,8 @@ N-bit overflow occurs. In a packet context, clock field names ending with `_begin` and `_end` have a special meaning: this refers to the timestamps at, respectively, -the beginning and the end of each packet. - +the beginning and the end of each packet. Those are required to be +complete representations of the clock value. ## A. Helper macros -- 2.11.0