Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F410C4724C for ; Thu, 30 Apr 2020 15:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAEC92076D for ; Thu, 30 Apr 2020 15:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbgD3Psn (ORCPT ); Thu, 30 Apr 2020 11:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726350AbgD3Psn (ORCPT ); Thu, 30 Apr 2020 11:48:43 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32DC4C035494 for ; Thu, 30 Apr 2020 08:48:43 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1jUBQY-0000Kb-1M; Thu, 30 Apr 2020 17:48:42 +0200 Date: Thu, 30 Apr 2020 17:48:42 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH 3/4] segtree: Merge get_set_interval_find() and get_set_interval_end() Message-ID: <20200430154841.GP15009@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20200430151408.32283-1-phil@nwl.cc> <20200430151408.32283-4-phil@nwl.cc> <20200430153729.GA3602@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430153729.GA3602@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Apr 30, 2020 at 05:37:29PM +0200, Pablo Neira Ayuso wrote: > On Thu, Apr 30, 2020 at 05:14:07PM +0200, Phil Sutter wrote: > > Both functions were very similar already. Under the assumption that they > > will always either see a range (or start of) that matches exactly or not > > at all, reduce complexity and make get_set_interval_find() accept NULL > > (left or) right values. This way it becomes a full replacement for > > get_set_interval_end(). > > I have to go back to the commit log of this patch, IIRC my intention > here was to allow users to ask for a single element, then return the > range that contains it. That was my suspicion as well, but while testing I found out that no matter what I passed to 'get element', I couldn't provoke a situation in which get_set_interval_find() would have left and right elements which didn't match exactly (or not at all). There must be some preparation happening before the call to get_set_decompose() which normalizes things. And still, If I disable the call to get_set_decompose() entirely, tests start failing. Cheers, Phil