From: Christoph Hellwig Date: Wed, 06 May 2020 06:13:26 +0000 Subject: Re: [PATCH V2 08/11] arch/kmap: Ensure kmap_prot visibility Message-Id: <20200506061326.GD5192@infradead.org> List-Id: References: <20200504010912.982044-1-ira.weiny@intel.com> <20200504010912.982044-9-ira.weiny@intel.com> In-Reply-To: <20200504010912.982044-9-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ira.weiny@intel.com Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Sun, May 03, 2020 at 06:09:09PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > We want to support kmap_atomic_prot() on all architectures and it makes > sense to define kmap_atomic() to use the default kmap_prot. > > So we ensure all arch's have a globally available kmap_prot either as a > define or exported symbol. FYI, I still think a #ifndef kmap_prot #define kmap_prot PAGE_KERNEL #endif in linux/highmem.h would be nicer. Then only xtensa and sparc need to override it and clearly stand out.