Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 757A1C28CBC for ; Wed, 6 May 2020 09:35:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E3FA2082E for ; Wed, 6 May 2020 09:35:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="Qq/O+DK/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E3FA2082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWGRw-0007Tm-S3; Wed, 06 May 2020 09:34:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWGRv-0007Th-Mm for xen-devel@lists.xenproject.org; Wed, 06 May 2020 09:34:43 +0000 X-Inumbo-ID: d0d74e98-8f7c-11ea-9e29-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d0d74e98-8f7c-11ea-9e29-12813bfff9fa; Wed, 06 May 2020 09:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=BP8uYz/aYWuKgcLUpwpdowh/5shn/LrRYs5btpMcU/E=; b=Qq/O+DK/vZdH44A7vk0UATJ7YG tBSh4Zpmk5wsZADQNk+xPLf2b0dj9rvsIyrz3bM4gfIslftWwp4t/vBFN/Hhia9TljOLbNBdc3p7Q mPeo93jX8gm6rqhJ/ypTp+Uki270gIHwFB4oVfMucy4spOvSWTUgonj6+7cwt/tndPVI=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWGRu-0000jH-03; Wed, 06 May 2020 09:34:42 +0000 Received: from 44.142.6.51.dyn.plus.net ([51.6.142.44] helo=debian) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jWGRt-0008BZ-M6; Wed, 06 May 2020 09:34:41 +0000 Date: Wed, 6 May 2020 10:34:39 +0100 From: Wei Liu To: Juergen Gross Subject: Re: [PATCH v3] tools/xenstore: don't store domU's mfn of ring page in xenstored Message-ID: <20200506093439.eqmuc26dglgiqdah@debian> References: <20200430053842.4376-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430053842.4376-1-jgross@suse.com> User-Agent: NeoMutt/20180716 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Apr 30, 2020 at 07:38:42AM +0200, Juergen Gross wrote: > The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) > of the domain's xenstore ring page and the event channel of the > domain for communicating with Xenstore. > > The gfn is not really needed. It is stored in the per-domain struct > in xenstored and in case of another XS_INTRODUCE for the domain it > is tested to match the original value. If it doesn't match the > command is aborted via EINVAL, otherwise the event channel to the > domain is recreated. > > As XS_INTRODUCE is limited to dom0 and there is no real downside of > recreating the event channel just omit the test for the gfn to > match and don't return EINVAL for multiple XS_INTRODUCE calls. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu