From: Tom Rini Date: Wed, 6 May 2020 11:31:39 -0400 Subject: [PATCH] Revert "mkimage: fit: Do not tail-pad fitImage with external data" In-Reply-To: <8864b7e6-0e03-6cde-d7cd-4d99bbf2040b@denx.de> References: <20200506150517.28103-1-trini@konsulko.com> <20200506151908.GL12564@bill-the-cat> <8864b7e6-0e03-6cde-d7cd-4d99bbf2040b@denx.de> Message-ID: <20200506153139.GM12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, May 06, 2020 at 05:23:55PM +0200, Marek Vasut wrote: > On 5/6/20 5:19 PM, Tom Rini wrote: > > On Wed, May 06, 2020 at 05:08:12PM +0200, Marek Vasut wrote: > >> On 5/6/20 5:05 PM, Tom Rini wrote: > >>> This has been reported to break booting of U-Boot from SPL on a number > >>> of platforms due to a lack of alignment of the external data. The > >>> issues this commit is addressing will need to be resolved another way. > >>> > >>> This reverts commit 20a154f95bfe0a3b5bfba90bea7f001c58217536. > >>> > >>> Reported-by: Alex Kiernan > >>> Reported-by: Michael Walle > >>> Signed-off-by: Tom Rini > >> > >> The commit message should also warn that this re-opens the data leak in > >> the padding. > > > > Sure. Are you going to send a patch switching to calloc or should I? > > I think the discussion about the padding requirement isn't finished yet? > See my remark about the load = <>; part. I'm unsure what more you need to provide a potential fix to the platforms that have reported breakage. I suspect you might even have a platform handy that is broken, given the imx platform. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: