From: Dan Carpenter Date: Fri, 08 May 2020 14:45:27 +0000 Subject: Re: [v3] tools/bootconfig: fix resource leak in apply_xbc() Message-Id: <20200508144527.GR1992@kadam> List-Id: References: <3569aa33-8963-966d-9247-ec79b3b3d56d@huawei.com> <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de> <559edb00-a03b-747e-8ba7-1f16285deefb@huawei.com> <65057e82-8002-4ec4-b714-25ac8d05cb68@web.de> <938cd0e9-d96b-766c-cfbc-4f0b73d97cd4@huawei.com> <20200508090053.430d28d7@gandalf.local.home> In-Reply-To: <20200508090053.430d28d7@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: Yunfeng Ye , Markus Elfring , Masami Hiramatsu , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Shiyuan Hu , Hewenliang On Fri, May 08, 2020 at 09:00:53AM -0400, Steven Rostedt wrote: > On Fri, 8 May 2020 19:42:56 +0800 > Yunfeng Ye wrote: > > > On 2020/5/8 19:30, Markus Elfring wrote: > > >> this change can fix the warning of tools. > > > > > > Would you like to point any specific source code analysis tools out > > > for this issue? > > > (Can a corresponding attribution become relevant for a clearer > > > change description?) > > > > > The tools we used is not for open source. it point out some error description like > > "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c. > > > > Can I only description: > > "Memory and resource leak is found by a static code analysis tools" ? thanks. > > Markus please stop! Your suggestions are just your preferences that are not > required for the kernel. > > Yunfeng, your v2 was fine and has already landed in Linus's tree. Feel free > to ignore Markus's suggestions in the future. There was actually a bug in v2. It exits with a non-zero instead of zero on success so it will mess up people's scripts. regards, dan carpenter