From: Tom Rini Date: Fri, 8 May 2020 12:19:02 -0400 Subject: [PATCH] cmd: env: fix unreachable statements In-Reply-To: <9921b3cc-7d35-215a-162c-59588ccaa3e3@gmx.de> References: <20200508055145.7621-1-takahiro.akashi@linaro.org> <9921b3cc-7d35-215a-162c-59588ccaa3e3@gmx.de> Message-ID: <20200508161902.GG12564@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, May 08, 2020 at 06:10:27PM +0200, Heinrich Schuchardt wrote: > On 08.05.20 07:51, AKASHI Takahiro wrote: > > C's switch statement takes an integer value for switching. > > As efi_status_t is defined as unsigned long and each error code has > > the top bit set, all "cases" cannot be reachable. > > > > Signed-off-by: AKASHI Takahiro > > Reported-by: Coverity (CID 300335) > > The requirement of C 1999 specification is: > "The controlling expression of a switch statement shall have integer > type." The requirement is not that the controlling expression should be int. > > GCC works fine with uint64_t as argument of a switch statement. OK, but for the record what about C11 with GNU extensions? > To me this is a false positive of Coverity. I can go mark it as such after the above is answered, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: