From: Joerg Roedel Subject: Re: [RFC PATCH 2/7] mm/vmalloc: Track which page-table levels were modified Date: Fri, 8 May 2020 23:23:21 +0200 Message-ID: <20200508212321.GR8135@suse.de> References: <20200508144043.13893-1-joro@8bytes.org> <20200508144043.13893-3-joro@8bytes.org> <20200508191048.GA2957@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200508191048.GA2957@hirez.programming.kicks-ass.net> Sender: linux-acpi-owner@vger.kernel.org To: Peter Zijlstra Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , rjw@rjwysocki.net, Arnd Bergmann , Andrew Morton , Steven Rostedt , Vlastimil Babka , Michal Hocko , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org List-Id: linux-arch.vger.kernel.org On Fri, May 08, 2020 at 09:10:48PM +0200, Peter Zijlstra wrote: > On Fri, May 08, 2020 at 04:40:38PM +0200, Joerg Roedel wrote: > > + if (mask & ARCH_PAGE_TABLE_SYNC_MASK) > > + arch_sync_kernel_mappings(start, end); > > So you're relying on the compiler DCE'ing the call in the 'normal' case. > > Works I suppose, but I went over the patches twice to look for a default > implementation of it before I figured that out ... Yes, works on all architectures I compile-tested this on, with gcc-9.3. I should probably add a comment about that. Joerg