Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0544C28CBC for ; Sat, 9 May 2020 15:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D6A2184D for ; Sat, 9 May 2020 15:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727863AbgEIPfa (ORCPT ); Sat, 9 May 2020 11:35:30 -0400 Received: from elvis.franken.de ([193.175.24.41]:46036 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727092AbgEIPfa (ORCPT ); Sat, 9 May 2020 11:35:30 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jXRVf-0005ZO-00; Sat, 09 May 2020 17:35:27 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 9AB96C044C; Sat, 9 May 2020 17:25:01 +0200 (CEST) Date: Sat, 9 May 2020 17:25:01 +0200 From: Thomas Bogendoerfer To: Huacai Chen Cc: "open list:MIPS" , Fuxin Zhang , Zhangjin Wu , Jiaxun Yang Subject: Re: [PATCH] MIPS: inst.h: Stop including asm.h to avoid various build failures Message-ID: <20200509152501.GA9125@alpha.franken.de> References: <1588930212-5255-1-git-send-email-chenhc@lemote.com> <20200508130149.GA14297@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, May 09, 2020 at 12:10:05PM +0800, Huacai Chen wrote: > On Fri, May 8, 2020 at 9:31 PM Thomas Bogendoerfer > wrote: > > > > On Fri, May 08, 2020 at 05:30:12PM +0800, Huacai Chen wrote: > > > Commit d339cd02b888eb8 ("MIPS: Move unaligned load/store helpers to > > > inst.h") causes a lot of build failures because macros in asm.h conflict > > > with various subsystems. Some of these conflictions has been fixed (such > > > as LONG, PANIC and PRINT) by adjusting asm.h, but some of them is nearly > > > impossible to fix (such as PTR and END). The only reason of including > > > asm.h in inst.h is that we need the PTR macro which is used by unaligned > > > load/store helpers. So in this patch we define a new PTR_STR macro and > > > use it to replace STR(PTR), then we can stop including asm.h to avoid > > > various build failures. > > > > > > Fixes: d339cd02b888eb8 ("MIPS: Move unaligned load/store helpers to inst.h") > > > Reported-by: kbuild test robot > > > Signed-off-by: Huacai Chen > > > --- > > > arch/mips/include/asm/inst.h | 184 ++++++++++++++++++++++--------------------- > > > > applied to mips-next. /me hopes this is the last fix... thanks > I think this is the last fix... and, does "MIPS: asm: Rename some > macros to avoid build errors" need to be reverted? let's keep it as it is now. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]