Return-Path: Date: Mon, 11 May 2020 09:42:43 +0200 From: Peter Zijlstra Subject: Re: [RFC PATCH 0/7] mm: Get rid of vmalloc_sync_(un)mappings() Message-ID: <20200511074243.GE2957@hirez.programming.kicks-ass.net> References: <20200508144043.13893-1-joro@8bytes.org> <20200508213609.GU8135@suse.de> <20200509175217.GV8135@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Andy Lutomirski Cc: Joerg Roedel , Joerg Roedel , X86 ML , "H. Peter Anvin" , Dave Hansen , "Rafael J. Wysocki" , Arnd Bergmann , Andrew Morton , Steven Rostedt , Vlastimil Babka , Michal Hocko , LKML , Linux ACPI , linux-arch , Linux-MM List-ID: Message-ID: <20200511074243.54tJKd0UkObDGtH-R5MoXGH9mdn1WlyKzSXzbnCkrHA@z> On Sat, May 09, 2020 at 12:05:29PM -0700, Andy Lutomirski wrote: > On x86_64, the only real advantage is that the handful of corner cases > that make vmalloc faults unpleasant (mostly relating to vmap stacks) > go away. On x86_32, a bunch of mind-bending stuff (everything your > series deletes but also almost everything your series *adds*) goes > away. There may be a genuine tiny performance hit on 2-level systems > due to the loss of huge pages in vmalloc space, but I'm not sure I > care or that we use them anyway on these systems. And PeterZ can stop > even thinking about RCU. > > Am I making sense? I think it'll work for x86_64 and that is really all I care about :-)