Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EC9CA90AF for ; Tue, 12 May 2020 16:29:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CF8A206CC for ; Tue, 12 May 2020 16:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="f5hvJZ26" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CF8A206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jYXm6-0004iC-B8; Tue, 12 May 2020 16:28:58 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jYXm6-0004i7-2T for xen-devel@lists.xenproject.org; Tue, 12 May 2020 16:28:58 +0000 X-Inumbo-ID: ac4c4e5e-946d-11ea-a2d8-12813bfff9fa Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac4c4e5e-946d-11ea-a2d8-12813bfff9fa; Tue, 12 May 2020 16:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1589300936; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9ntlV26wEcF4XSi0g3CxgD+0WFwGxy7ndEp9NSgUC9o=; b=f5hvJZ26SLmrpXoi96zv1gyWv6P4jcRtUsqwV80kD18sJr45kk6n+gxq D+cRwgIXFH0xvLbmPyNG8rhGyZqg18mxJ6e4X2IkXwhD7BRH6VPyWcPN7 0S8mVpUAmv3ALuaXvEkk4yvPB4reB0z7Wx6seQdmlqmV57vfUXsvYjCue g=; Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com; dmarc=pass (p=none dis=none) d=citrix.com IronPort-SDR: +u5DxnAfrkcTxy86LoqbYdWGWgD4MDiNoRN4uyQr9EyenJJIeAcXbodTFOdmmyak2oVBpDV6hg RiDfOTSFS0LWue0y5Z1Fqv7GNdzmzQuHOriNg9WVWIe2BSWaK0I6uNlnH72X6I4x/1d8wJJOwE PfIG72bG3sz5okjDrUuB6imabWL7kOmnjDq4lEVFVWKLyDha0gd1CVDLGRInI3ljQrNRB7jpkj IAXHjxdKlR2bWaKOPvpuPk7dFzLe9kMUTuRVPC/O38BljzxfvWLg1+kOi/7/mBn10Rekb50ef3 o+I= X-SBRS: 2.7 X-MesageID: 18028713 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,384,1583211600"; d="scan'208";a="18028713" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/guest: Fix assembler warnings with newer binutils Date: Tue, 12 May 2020 17:28:30 +0100 Message-ID: <20200512162830.5912-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" GAS of at least version 2.34 complains: hypercall_page.S: Assembler messages: hypercall_page.S:24: Warning: symbol 'HYPERCALL_set_trap_table' already has its type set ... hypercall_page.S:71: Warning: symbol 'HYPERCALL_arch_7' already has its type set This is because the whole page is declared as STT_OBJECT, and then every hypercall within it is declared as STT_FUNC. As these are function-like and in .text, retain the STT_FUNC type and drop STT_OBJECT. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné Alternative suggestions welcome. I've got half a mind to strip the unused hypercalls, as a large chunk of them are PV only and will never be used by a PVH Xen. This would also remove the existing alias between hypercall_page and HYPERCALL_set_trap_table. --- xen/arch/x86/guest/xen/hypercall_page.S | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/guest/xen/hypercall_page.S b/xen/arch/x86/guest/xen/hypercall_page.S index 6485e9150e..9673846b7d 100644 --- a/xen/arch/x86/guest/xen/hypercall_page.S +++ b/xen/arch/x86/guest/xen/hypercall_page.S @@ -8,7 +8,6 @@ GLOBAL(hypercall_page) /* Poisoned with `ret` for safety before hypercalls are set up. */ .fill PAGE_SIZE, 1, 0xc3 - .type hypercall_page, STT_OBJECT .size hypercall_page, PAGE_SIZE /* -- 2.11.0